This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
release mysql dependence in syncer test (1) #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
3pointer
added
priority/unimportant
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
==============================================
- Coverage 58.9954% 58.89% -0.1054%
==============================================
Files 123 123
Lines 14335 14055 -280
==============================================
- Hits 8457 8277 -180
+ Misses 5008 4948 -60
+ Partials 870 830 -40 |
3pointer
force-pushed
the
syncer_mock_test
branch
from
8b137ef
to
6cbeb0f
Compare
|
/run-all-tests |
3 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
3pointer
force-pushed
the
syncer_mock_test
branch
from
ff10fe9
to
9aa3a1c
Compare
|
/run-all-tests |
3pointer
force-pushed
the
syncer_mock_test
branch
from
9aa3a1c
to
ea258de
Compare
3pointer
force-pushed
the
syncer_mock_test
branch
from
2eac360
to
34fb516
Compare
IANTHEREAL
reviewed
Jul 29, 2019
syncer/syncer_test.go
Outdated
| previousGTIDSetStr := "3ccc475b-2343-11e7-be21-6c0b84d59f30:1-14,406a3f61-690d-11e7-87c5-6c92bf46f384:1-94321383" | ||
| previousGTIDSet, err := gtid.ParserGTID(s.cfg.Flavor, previousGTIDSetStr) | ||
| if err != nil { | ||
| log.L().Fatal("", zap.Error(err)) |
There was a problem hiding this comment.
it's better to use check.FailNow/Fatalf to stop unit test
IANTHEREAL
reviewed
Jul 29, 2019
| @@ -80,11 +84,26 @@ func (s *testSyncerSuite) SetUpSuite(c *C) { | |||
|
|
|||
| s.resetMaster() | |||
There was a problem hiding this comment.
still need to leave them?
s.resetMaster()
s.resetBinlogSyncer()
There was a problem hiding this comment.
some tests still use them, but I will remove them eventually in other PRs
IANTHEREAL
reviewed
Jul 29, 2019
syncer/syncer_test.go
Outdated
| @@ -222,33 +243,117 @@ func (s *testSyncerSuite) TestSelectTable(c *C) { | |||
| {Schema: "~^ptest*", Name: "~^t.*"}, | |||
| }, | |||
| } | |||
| s.resetEventsGenerator() | |||
There was a problem hiding this comment.
We can define a more generic object to represent the test case, like
type binlogEvents []binlogEvent
type binlogEvent struct {
typ string
arguments []interface{}
}
and an events generation function
function testGenerateEvent(binlogEvents) []*replication.BinlogEvent
they would save many codes
|
Rest LGTM |
|
/run-all-tests |
|
/run-all-tests |
amyangfei
reviewed
Jul 31, 2019
amyangfei
reviewed
Jul 31, 2019
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
amyangfei
added
status/LGT1
|
Good Job！LGTM |
IANTHEREAL
approved these changes
Aug 1, 2019
IANTHEREAL
added
status/LGT2
22 tasks
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Release mysql dependencies in syncer test, this is the first part change, there are 4 syncer tests remain mysql dependencies need to realease, and I'll finish them in other PR.
What is changed and how it works?
use sql mock and mock binlog events in
pkg/binlog/eventCheck List
Tests