Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

ha: remove unused etcd task cfg key #2180

Merged
merged 3 commits into from
Oct 8, 2021

Conversation

Ehco1996
Copy link
Contributor

What problem does this PR solve?

as title

What is changed and how it works?

after this #1323, we don't store taskConfig in etcd, so we can remove that code

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 28, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Ehco1996 Ehco1996 changed the title ha: remove unuse etcd task cfg key ha: remove unused etcd task cfg key Sep 28, 2021
@Ehco1996 Ehco1996 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 28, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Sep 29, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Oct 8, 2021
@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8bba9ab

@ti-chi-bot ti-chi-bot merged commit 941915b into pingcap:master Oct 8, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2193.

@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Oct 8, 2021

We may need to add a TODO: prune them in etcd for these unused keys, otherwise these keys will remain forever when the user upgrade from an old cluster.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 size/XS status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge status/PTAL This PR is ready for review. Add this label back after committing new changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants