Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dm-worker: fix panic in query status (#274) #275

Merged
merged 1 commit into from
Sep 9, 2019
Merged

dm-worker: fix panic in query status (#274) #275

merged 1 commit into from
Sep 9, 2019

Conversation

amyangfei
Copy link
Contributor

cherry-pick #274 into release-1.0

@amyangfei amyangfei added status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Sep 9, 2019
csuzhangxc
csuzhangxc reviewed Sep 9, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 9, 2019
@csuzhangxc
Copy link
Member

@WangXiangUSTC PTAL

@amyangfei amyangfei added the needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated label Sep 9, 2019
WangXiangUSTC
WangXiangUSTC approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 9, 2019
@amyangfei amyangfei merged commit 2f0b84f into pingcap:release-1.0 Sep 9, 2019
@amyangfei amyangfei deleted the cherry-pick-274 branch September 9, 2019 06:03
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amyangfei @csuzhangxc @WangXiangUSTC