Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: fix server startup panic (#298) #301

Merged
merged 2 commits into from
Sep 26, 2019

Conversation

amyangfei
Copy link
Contributor

cherry-pick #298 into release-1.0

@amyangfei amyangfei added status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Sep 25, 2019
@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #301 into release-1.0 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-1.0      #301   +/-   ##
=============================================
  Coverage       60.261%   60.261%           
=============================================
  Files              134       134           
  Lines            14789     14789           
=============================================
  Hits              8912      8912           
  Misses            5039      5039           
  Partials           838       838

@WangXiangUSTC
Copy link
Contributor

LGTM

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 26, 2019
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei amyangfei merged commit 8cf34a2 into pingcap:release-1.0 Sep 26, 2019
@amyangfei amyangfei deleted the cherry-pick-298 branch September 26, 2019 07:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants