Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dmctl: add command mode (#287) #364

Merged
merged 18 commits into from
Nov 19, 2019
Merged

dmctl: add command mode (#287) #364

merged 18 commits into from
Nov 19, 2019

Conversation

sre-bot
Copy link

@sre-bot sre-bot commented Nov 18, 2019

cherry-pick #287 to release-1.0

What problem does this PR solve?

add command mode to control task

What is changed and how it works?

add command mode in dmctl.main

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the dm/dm-ansible
  • Need to be included in the release note

@sre-bot sre-bot mentioned this pull request Nov 18, 2019
Merged
@sre-bot sre-bot added priority/important Major change, requires approval from ≥2 primary reviewers needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated type/cherry-pick This PR is just a cherry-pick (backport) type/feature New feature labels Nov 18, 2019
@csuzhangxc
Copy link
Member

/run-all-tests tidb=release-3.0

csuzhangxc
csuzhangxc reviewed Nov 19, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added the status/LGT1 One reviewer already commented LGTM label Nov 19, 2019
@csuzhangxc
Copy link
Member

@WangXiangUSTC PTAL

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #364 into release-1.0 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-1.0       #364   +/-   ##
==============================================
  Coverage      57.2975%   57.2975%           
==============================================
  Files              158        158           
  Lines            16067      16067           
==============================================
  Hits              9206       9206           
  Misses            5955       5955           
  Partials           906        906

WangXiangUSTC
WangXiangUSTC approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Nov 19, 2019
@csuzhangxc csuzhangxc merged commit 407b06f into pingcap:release-1.0 Nov 19, 2019
@ericsyh ericsyh added this to the v1.0.2 milestone Nov 22, 2019
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
already-update-docs The docs related to this PR already updated. Add this label once the docs are updated already-update-release-note The release note is updated. Add this label once the release note is updated priority/important Major change, requires approval from ≥2 primary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport) type/feature New feature
Projects
None yet
Milestone
v1.0.3
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @csuzhangxc @WangXiangUSTC @ericsyh @3pointer