This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
refine mydumper exits error log #660
Merged
lichunzhu
merged 4 commits into
pingcap:release-1.0
from
lichunzhu:release1.0/refineMydumperLog
May 14, 2020
Merged
refine mydumper exits error log #660
lichunzhu
merged 4 commits into
pingcap:release-1.0
from
lichunzhu:release1.0/refineMydumperLog
May 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichunzhu
added
the
status/PTAL
This PR is ready for review. Add this label back after committing new changes
label
May 13, 2020
Codecov Report
@@ Coverage Diff @@
## release-1.0 #660 +/- ##
==============================================
Coverage 57.8452% 57.8452%
==============================================
Files 166 166
Lines 17004 17004
==============================================
Hits 9836 9836
Misses 6212 6212
Partials 956 956 |
csuzhangxc
reviewed
May 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
csuzhangxc
added
status/LGT1
One reviewer already commented LGTM
and removed
status/PTAL
This PR is ready for review. Add this label back after committing new changes
labels
May 14, 2020
WangXiangUSTC
approved these changes
May 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WangXiangUSTC
added
status/LGT2
Two reviewers already commented LGTM, ready for merge
and removed
status/LGT1
One reviewer already commented LGTM
labels
May 14, 2020
/run-all-tests |
1 similar comment
/run-all-tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
mydumper exits log is very confusing now
What is changed and how it works?
distinguish exits normally with exits with error by different logs.
Check List
Tests