Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

refine mydumper exits error log #660

Merged
merged 4 commits into from
May 14, 2020

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

mydumper exits log is very confusing now

What is changed and how it works?

distinguish exits normally with exits with error by different logs.

Check List

Tests

  • Unit test
  • Integration test

@lichunzhu lichunzhu added the status/PTAL This PR is ready for review. Add this label back after committing new changes label May 13, 2020
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #660 into release-1.0 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-1.0       #660   +/-   ##
==============================================
  Coverage      57.8452%   57.8452%           
==============================================
  Files              166        166           
  Lines            17004      17004           
==============================================
  Hits              9836       9836           
  Misses            6212       6212           
  Partials           956        956           

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels May 14, 2020
@csuzhangxc csuzhangxc added this to the v1.0.6 milestone May 14, 2020
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels May 14, 2020
@lichunzhu
Copy link
Contributor Author

/run-all-tests

1 similar comment
@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu lichunzhu merged commit 1815a16 into pingcap:release-1.0 May 14, 2020
@lichunzhu lichunzhu deleted the release1.0/refineMydumperLog branch May 15, 2020 02:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants