This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
syncer: refine heartbeat #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csuzhangxc
added
status/WIP
Codecov Report
@@ Coverage Diff @@
## release-1.0 #704 +/- ##
==============================================
Coverage 57.9412% 57.9412%
==============================================
Files 166 166
Lines 16981 16981
==============================================
Hits 9839 9839
Misses 6187 6187
Partials 955 955 |
|
/run-all-tests |
csuzhangxc
added
status/PTAL
|
@GMHDBJD PTAL |
GMHDBJD
added
status/LGT1
| @@ -101,8 +101,8 @@ function run() { | |||
| # use sync_diff_inspector to check data now! | |||
| check_sync_diff $WORK_DIR $cur/conf/diff_config.toml | |||
|
|
|||
| check_metric $WORKER1_PORT 'dm_syncer_replication_lag{task="test"}' 3 0 1 | |||
| check_metric $WORKER2_PORT 'dm_syncer_replication_lag{task="test"}' 3 0 1 | |||
| check_metric $WORKER1_PORT 'dm_syncer_replication_lag{task="test"}' 3 0 2 | |||
There was a problem hiding this comment.
why need to increase the upper to 2? It seems that use UTC_TIMESTAMP(6) to replace UTC_TIMESTAMP when update ts will decrease the replication lag.
There was a problem hiding this comment.
I saw lag with 1.x (but < 1.5) in some cases. in the old UTC_TIMESTAMP it ==1, but now it > 1.
|
LGTM |
WangXiangUSTC
added
status/LGT2
WangXiangUSTC
approved these changes
Jun 11, 2020
csuzhangxc
added a commit
to csuzhangxc/dm
that referenced
this pull request
Jun 11, 2020
csuzhangxc
added a commit
that referenced
this pull request
Jun 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
UTC_TIMESTAMP(6)to replaceUTC_TIMESTAMP()Check List
Tests
Related changes