Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

check_task: ping db when apply dbconfig #769

Merged
merged 5 commits into from
Jul 2, 2020
Merged

check_task: ping db when apply dbconfig #769

merged 5 commits into from
Jul 2, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Jun 30, 2020

What problem does this PR solve?

close #766

What is changed and how it works?

ping database when apply db config

Check List

Tests

  • Integration test

@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Jun 30, 2020

/run-all-tests

@GMHDBJD GMHDBJD added the status/WIP This PR is still work in progress label Jun 30, 2020
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Jun 30, 2020

/run-all-tests

@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Jul 1, 2020

/run-all-tests

@GMHDBJD GMHDBJD added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 and removed status/WIP This PR is still work in progress labels Jul 1, 2020
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Jul 1, 2020

/run-all-tests

1 similar comment
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Jul 1, 2020

/run-all-tests

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #769 into master will increase coverage by 0.0902%.
The diff coverage is 51.2087%.

@@               Coverage Diff                @@
##             master       #769        +/-   ##
================================================
+ Coverage   57.0981%   57.1884%   +0.0902%     
================================================
  Files           205        206         +1     
  Lines         21104      21319       +215     
================================================
+ Hits          12050      12192       +142     
- Misses         7890       7942        +52     
- Partials       1164       1185        +21

@lance6716
Copy link
Collaborator

LGTM

@lance6716 lance6716 added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jul 2, 2020
WangXiangUSTC
WangXiangUSTC approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jul 2, 2020
@GMHDBJD GMHDBJD merged commit de08299 into pingcap:master Jul 2, 2020
@ti-srebot
Copy link

cherry pick to release-1.0 failed

GMHDBJD added a commit to GMHDBJD/dm that referenced this pull request Jul 2, 2020
@GMHDBJD
check_task: ping db when apply dbconfig (pingcap#769)
3b752b8
@GMHDBJD GMHDBJD mentioned this pull request Jul 2, 2020
Merged
@csuzhangxc csuzhangxc added this to the v2.0.0 RC milestone Jul 15, 2020
@lance6716 lance6716 added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.0 RC
Development

Successfully merging this pull request may close these issues.

check task doesn't check downstream database connection.
5 participants
@GMHDBJD @lance6716 @ti-srebot @WangXiangUSTC @csuzhangxc