This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
test: add online ddl test in integration test #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
priority/normal
amyangfei
force-pushed
the
online-ddl-test
branch
from
dfba24d
to
2debe90
Compare
|
/run-all-tests |
kennytm
reviewed
Mar 18, 2019
tests/_utils/run_sql_file
Outdated
| @@ -1,8 +1,9 @@ | |||
| #!/bin/sh | |||
| # parameter 1: sql file | |||
| # parameter 3: host | |||
There was a problem hiding this comment.
Err must keep the list in order 😕
amyangfei
added
status/PTAL
|
PTAL @GregoryIan @csuzhangxc |
22 tasks
csuzhangxc
reviewed
Mar 19, 2019
Co-Authored-By: amyangfei <amyangfei@gmail.com>
csuzhangxc
reviewed
Mar 19, 2019
| @@ -127,16 +126,6 @@ func (g *Ghost) Apply(tables []*filter.Table, statement string, stmt ast.StmtNod | |||
| return nil, schema, table, nil | |||
| } | |||
|
|
|||
| // InOnlineDDL implements interface | |||
| func (g *Ghost) InOnlineDDL(schema, table string) bool { | |||
There was a problem hiding this comment.
@GregoryIan what's your opinion about removing these unused interfaces.
There was a problem hiding this comment.
It doesn't matter, add it back when you need it.
csuzhangxc
added
status/LGT1
|
LGTM |
|
Good Job |
kennytm
added
status/LGT2
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add online ddl test in integration test
What is changed and how it works?
gh-ostandpt-soctools in JenkinsCICheck List
Tests