Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

loader: support percent escape in dump files (#980) #991

Merged
merged 3 commits into from
Sep 4, 2020

Conversation

ti-srebot
Copy link

cherry-pick #980 to release-2.0


What problem does this PR solve?

close #940

What is changed and how it works?

dumpling now percent escape some characters in filenames, so unescape them in proper place

Check List

Tests

  • Integration test

Code changes

Side effects

  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch

@ti-srebot ti-srebot added priority/normal Minor change, requires approval from ≥1 primary reviewer type/cherry-pick This PR is just a cherry-pick (backport) type/feature New feature labels Sep 4, 2020
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Sep 4, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 4, 2020
@lance6716 lance6716 merged commit c8287f1 into pingcap:release-2.0 Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport) type/feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants