add content about lazy uniqueness check #11166

ekexium · 2022-09-01T07:14:18Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Add content about the new feature lazy uniqueness check.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):
- tracking issue: Loosen pessimistic transactions: skip acquiring locks for some statements tidb#36579

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2022-09-01T07:14:21Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: ekexium <eke@fastmail.com>

constraints.md

Signed-off-by: ekexium <eke@fastmail.com>

constraints.md

system-variables.md

error-codes.md

constraints.md

Co-authored-by: Grace Cai <qqzczy@126.com>

Signed-off-by: ekexium <eke@fastmail.com>

error-codes.md

constraints.md

pessimistic-transaction.md

constraints.md

error-codes.md

pessimistic-transaction.md

system-variables.md

Signed-off-by: ekexium <eke@fastmail.com>

Co-authored-by: Grace Cai <qqzczy@126.com> Co-authored-by: xixirangrang <hfxsd@hotmail.com>

Signed-off-by: ekexium <eke@fastmail.com>

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

songrijie · 2022-09-16T06:20:30Z

constraints.md

+ERROR 1062 (23000): Duplicate entry 'bill' for key 'username'
+```
+
+对于悲观事务，你可以设置变量 [`tidb_constraint_check_in_place_pessimistic`](/system-variables.md#tidb_constraint_check_in_place_pessimistic-从-v630-版本开始引入) 为 `0` 来推迟唯一约束检查，到下一次对该唯一索引项加锁时或事务提交时再进行检查，同时也跳过对该悲观锁加锁，以获得更好的性能。此时需要注意：


“以获得更好的性能” 建议改成 “在批量操作时获得更好的性能”

不批量也有改进，感觉没啥影响。

songrijie · 2022-09-16T06:23:35Z

rest LGTM

Signed-off-by: ekexium <eke@fastmail.com>

hfxsd

LGTM

system-variables.md

Signed-off-by: ekexium <eke@fastmail.com>

constraints.md

error-codes.md

system-variables.md

Co-authored-by: Grace Cai <qqzczy@126.com>

…cs-cn into pr/11166

qiancai · 2022-09-19T03:44:34Z

/remove-status LGT1
/status LGT2

qiancai · 2022-09-19T03:44:43Z

/merge

ti-chi-bot · 2022-09-19T03:44:46Z

This pull request has been accepted and is ready to merge.

Commit hash: 5815435

ti-chi-bot requested a review from TomShawn September 1, 2022 07:14

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 1, 2022

ekexium force-pushed the lazy-uniqueness-check branch from 13d0c27 to ec19dab Compare September 1, 2022 07:20

shichun-0415 added translation/doing This PR’s assignee is translating this PR. v6.3 This PR/issue applies to TiDB v6.3. and removed missing-translation-status This PR does not have translation status info. labels Sep 1, 2022

shichun-0415 requested review from qiancai and removed request for TomShawn September 1, 2022 07:37

shichun-0415 assigned qiancai Sep 1, 2022

ekexium force-pushed the lazy-uniqueness-check branch 2 times, most recently from 736085d to 0642b6c Compare September 1, 2022 08:46

ekexium requested review from sticnarf and cfzjywxk September 1, 2022 09:41

ekexium force-pushed the lazy-uniqueness-check branch from 0642b6c to 1767f67 Compare September 1, 2022 09:43

add content about lazy uniqueness check

09b7fd2

Signed-off-by: ekexium <eke@fastmail.com>

ekexium force-pushed the lazy-uniqueness-check branch from 1767f67 to 09b7fd2 Compare September 1, 2022 09:44

sticnarf reviewed Sep 2, 2022

View reviewed changes

constraints.md Outdated Show resolved Hide resolved

ekexium force-pushed the lazy-uniqueness-check branch 2 times, most recently from b93059c to ce85c29 Compare September 2, 2022 06:29

reorder examples

2e4e5af

Signed-off-by: ekexium <eke@fastmail.com>

ekexium force-pushed the lazy-uniqueness-check branch from ce85c29 to 2e4e5af Compare September 2, 2022 06:30

cfzjywxk reviewed Sep 2, 2022

View reviewed changes

constraints.md Outdated Show resolved Hide resolved

qiancai reviewed Sep 6, 2022

View reviewed changes

Apply suggestions from code review

55cb01f

Co-authored-by: Grace Cai <qqzczy@126.com>

shichun-0415 added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Sep 7, 2022

ekexium force-pushed the lazy-uniqueness-check branch from 565d3fb to 1658635 Compare September 7, 2022 12:11

adderss comments

f7a646a

Signed-off-by: ekexium <eke@fastmail.com>

ekexium force-pushed the lazy-uniqueness-check branch from 1658635 to f7a646a Compare September 7, 2022 12:13

resolve comments

ede6353

Signed-off-by: ekexium <eke@fastmail.com>

cfzjywxk approved these changes Sep 16, 2022

View reviewed changes

error-codes.md Outdated Show resolved Hide resolved

qiancai reviewed Sep 16, 2022

View reviewed changes

constraints.md Outdated Show resolved Hide resolved

sticnarf reviewed Sep 16, 2022

View reviewed changes

pessimistic-transaction.md Outdated Show resolved Hide resolved

hfxsd reviewed Sep 16, 2022

View reviewed changes

resolve comments

cbb58b1

Signed-off-by: ekexium <eke@fastmail.com>

ekexium force-pushed the lazy-uniqueness-check branch from 43633ab to cbb58b1 Compare September 16, 2022 04:09

ekexium and others added 3 commits September 16, 2022 12:14

Apply suggestions from code review

00d9594

Co-authored-by: Grace Cai <qqzczy@126.com> Co-authored-by: xixirangrang <hfxsd@hotmail.com>

resolve comments

7125c65

Signed-off-by: ekexium <eke@fastmail.com>

Apply suggestions from code review

6124738

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

sticnarf approved these changes Sep 16, 2022

View reviewed changes

songrijie reviewed Sep 16, 2022

View reviewed changes

fix error 8147

05e8ab5

Signed-off-by: ekexium <eke@fastmail.com>

hfxsd approved these changes Sep 16, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2022

hfxsd reviewed Sep 16, 2022

View reviewed changes

system-variables.md Show resolved Hide resolved

hfxsd reviewed Sep 16, 2022

View reviewed changes

system-variables.md Show resolved Hide resolved

change 0/1 to off/on

c5d45a5

Signed-off-by: ekexium <eke@fastmail.com>

qiancai reviewed Sep 19, 2022

View reviewed changes

ekexium and others added 3 commits September 19, 2022 10:33

Apply suggestions from code review

9bb363d

Co-authored-by: Grace Cai <qqzczy@126.com>

change true to on

9891f07

Merge branch 'lazy-uniqueness-check' of https://github.com/ekexium/do…

5815435

…cs-cn into pr/11166

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 19, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 19, 2022

ti-chi-bot merged commit 7b11ffa into pingcap:master Sep 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add content about lazy uniqueness check #11166

add content about lazy uniqueness check #11166

ekexium commented Sep 1, 2022 •

edited

Loading

ti-chi-bot commented Sep 1, 2022 •

edited

Loading

songrijie Sep 16, 2022

ekexium Sep 16, 2022

songrijie commented Sep 16, 2022

hfxsd left a comment

qiancai commented Sep 19, 2022

qiancai commented Sep 19, 2022

ti-chi-bot commented Sep 19, 2022

add content about lazy uniqueness check #11166

add content about lazy uniqueness check #11166

Conversation

ekexium commented Sep 1, 2022 • edited Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

ti-chi-bot commented Sep 1, 2022 • edited Loading

songrijie Sep 16, 2022

Choose a reason for hiding this comment

ekexium Sep 16, 2022

Choose a reason for hiding this comment

songrijie commented Sep 16, 2022

hfxsd left a comment

Choose a reason for hiding this comment

qiancai commented Sep 19, 2022

qiancai commented Sep 19, 2022

ti-chi-bot commented Sep 19, 2022

ekexium commented Sep 1, 2022 •

edited

Loading

ti-chi-bot commented Sep 1, 2022 •

edited

Loading