Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backup: change the location for s3-multi-part-size #11568

Merged
merged 1 commit into from
Oct 11, 2022
Merged

backup: change the location for s3-multi-part-size #11568

merged 1 commit into from
Oct 11, 2022

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Oct 11, 2022 •
edited by shichun-0415
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

change the location of s3-multi-part-size from causal-ts to backup

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@3pointer 3pointer requested a review from shichun-0415 October 11, 2022 07:46
@ti-chi-bot ti-chi-bot requested a review from TomShawn October 11, 2022 07:46
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 11, 2022
shichun-0415
shichun-0415 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 11, 2022
@shichun-0415 shichun-0415 added translation/doing This PR’s assignee is translating this PR. require-LGT1 Indicates that the PR requires an LGTM. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). needs-cherry-pick-release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. and removed missing-translation-status This PR does not have translation status info. labels Oct 11, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 68b57bd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 11, 2022
@shichun-0415 shichun-0415 self-assigned this Oct 11, 2022
@shichun-0415 shichun-0415 removed the request for review from TomShawn October 11, 2022 08:05
@ti-chi-bot ti-chi-bot merged commit 6d549a3 into pingcap:master Oct 11, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11569.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Oct 11, 2022
@3pointer @ti-chi-bot
This is an automated cherry-pick of pingcap#11568
d805e1d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Oct 11, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11570.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Oct 11, 2022
@3pointer @ti-chi-bot
This is an automated cherry-pick of pingcap#11568
68e6df9 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11571.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Oct 11, 2022
@3pointer @ti-chi-bot
This is an automated cherry-pick of pingcap#11568
86359e0 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11572.

This was referenced Oct 11, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11573.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11574.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Oct 11, 2022
@3pointer @ti-chi-bot
This is an automated cherry-pick of pingcap#11568
0feba10 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@shichun-0415 shichun-0415 added the type/enhancement The issue or PR belongs to an enhancement. label Oct 11, 2022
ti-chi-bot added a commit that referenced this pull request Oct 11, 2022
@ti-chi-bot
backup: change the location for s3-multi-part-size (#11568) (#11572)
e406b5f
ti-chi-bot added a commit that referenced this pull request Oct 11, 2022
@ti-chi-bot
backup: change the location for s3-multi-part-size (#11568) (#11573)
dfbc162
@shichun-0415 shichun-0415 mentioned this pull request Oct 12, 2022
Merged
14 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 12, 2022
This was referenced Oct 12, 2022
Merged
Merged
Merged
Merged
Merged
Merged
ti-chi-bot added a commit that referenced this pull request Oct 12, 2022
@ti-chi-bot
backup: change the location for s3-multi-part-size (#11568) (#11571)
d2510a9
shichun-0415 added a commit that referenced this pull request Oct 12, 2022
@ti-chi-bot @3pointer @shichun-0415
backup: change the location for s3-multi-part-size (#11568) (#11574)
0411f5a 
* This is an automated cherry-pick of #11568

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* resolve conflict

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Co-authored-by: 3pointer <luancheng@pingcap.com>
Co-authored-by: shichun-0415 <lishichun@pingcap.com>
ti-chi-bot added a commit that referenced this pull request Oct 12, 2022
@ti-chi-bot
backup: change the location for s3-multi-part-size (#11568) (#11570)
541ea68
ti-chi-bot added a commit that referenced this pull request Oct 12, 2022
@ti-chi-bot
backup: change the location for s3-multi-part-size (#11568) (#11569)
11e395b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees

@shichun-0415 shichun-0415

Labels
area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3pointer @ti-chi-bot @shichun-0415