Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb: add document for external timestamp read #11583

Merged
merged 3 commits into from
Nov 2, 2022
Merged

tidb: add document for external timestamp read #11583

merged 3 commits into from
Nov 2, 2022

Conversation

YangKeao
Copy link
Member

Signed-off-by: YangKeao yangkeao@chunibyo.icu

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add a document for external timestamp read and related system variables.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

@YangKeao YangKeao added the v6.4 This PR/issue applies to TiDB v6.4. label Oct 12, 2022
@YangKeao YangKeao requested a review from Oreoxmt October 12, 2022 04:24
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Oct 12, 2022
@CLAassistant
Copy link

CLAassistant commented Oct 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 12, 2022
@Oreoxmt Oreoxmt added the translation/from-docs This PR is translated from a PR in pingcap/docs. label Oct 12, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Oct 12, 2022
@YangKeao YangKeao force-pushed the add-doc-for-external-timestamp-read branch from 6e0df8a to bf78515 Compare October 12, 2022 04:41
@Oreoxmt Oreoxmt added area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Oct 12, 2022
@Oreoxmt Oreoxmt self-assigned this Oct 12, 2022
@easonn7
Copy link
Collaborator

easonn7 commented Oct 12, 2022

LGTM

@Oreoxmt Oreoxmt requested a review from easonn7 October 12, 2022 08:31
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 12, 2022

/status LGT1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2022
@YangKeao YangKeao force-pushed the add-doc-for-external-timestamp-read branch from bf78515 to 08e29dd Compare October 12, 2022 09:32
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 12, 2022

/status LGT1

@Oreoxmt Oreoxmt removed the request for review from easonn7 October 12, 2022 09:39
Oreoxmt
Oreoxmt reviewed Oct 12, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
@YangKeao YangKeao force-pushed the add-doc-for-external-timestamp-read branch from 08e29dd to 8527e37 Compare October 12, 2022 14:48
Oreoxmt
Oreoxmt reviewed Oct 18, 2022
View reviewed changes
stale-read.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
tidb-external-ts.md Outdated Show resolved Hide resolved
@YangKeao YangKeao force-pushed the add-doc-for-external-timestamp-read branch from 8527e37 to 7a59f0b Compare October 19, 2022 05:51
@YangKeao
tidb: add document for external timestamp read
d7985d2 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao YangKeao force-pushed the add-doc-for-external-timestamp-read branch from 7a59f0b to d7985d2 Compare October 19, 2022 05:52
@Oreoxmt Oreoxmt force-pushed the add-doc-for-external-timestamp-read branch from debfe4e to 3e8de58 Compare October 19, 2022 08:08
@Oreoxmt Oreoxmt self-requested a review October 19, 2022 08:09
Oreoxmt
Oreoxmt approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 19, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 19, 2022
shichun-0415
shichun-0415 approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

system-variables.md Show resolved Hide resolved
system-variables.md Show resolved Hide resolved
@Oreoxmt @YangKeao
review: fix format
6a9113a 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao YangKeao force-pushed the add-doc-for-external-timestamp-read branch from 3e8de58 to 6a9113a Compare October 25, 2022 06:12
@Oreoxmt Oreoxmt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 1, 2022

DNM until pingcap/tidb#38276 is merged

@Oreoxmt Oreoxmt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2a2abcc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 2, 2022
@ti-chi-bot ti-chi-bot merged commit ab3fe16 into pingcap:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.4 This PR/issue applies to TiDB v6.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@YangKeao @ti-chi-bot @CLAassistant @easonn7 @Oreoxmt @lcwangchao @shichun-0415