Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv: add new config raftstore.apply-yield-write-size #11831

Merged
merged 7 commits into from
Nov 7, 2022
Merged

tikv: add new config raftstore.apply-yield-write-size #11831

merged 7 commits into from
Nov 7, 2022

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Oct 28, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@glorv glorv requested a review from qiancai October 28, 2022 10:11
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2022
@glorv
Copy link
Contributor Author

glorv commented Oct 28, 2022

waiting for tikv/tikv#13594 to be merged first.

@glorv glorv force-pushed the apply-yield-msg-size branch from 19181ab to 5f74bc8 Compare October 28, 2022 10:18
@glorv glorv mentioned this pull request Oct 28, 2022
Merged
14 tasks
@qiancai qiancai added translation/doing This PR’s assignee is translating this PR. v6.4 This PR/issue applies to TiDB v6.4. labels Oct 31, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Oct 31, 2022
@qiancai qiancai self-assigned this Oct 31, 2022
@qiancai qiancai added the area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. label Oct 31, 2022
qiancai
qiancai reviewed Oct 31, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
@glorv glorv requested a review from BusyJay October 31, 2022 02:25
@glorv
Copy link
Contributor Author

glorv commented Oct 31, 2022

@BusyJay PTAL, thanks

@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 31, 2022
BusyJay
BusyJay reviewed Oct 31, 2022
View reviewed changes
dynamic-config.md Outdated
@@ -150,6 +150,7 @@ show warnings;
| raftstore.merge-check-tick-interval | 触发 Merge 完成检查的时间间隔 |
| raftstore.cleanup-import-sst-interval | 触发检查过期 SST 文件的时间间隔 |
| raftstore.local-read-batch-size | 一轮处理读请求的最大个数 |
| raftstore.apply-yield-msg-size | Apply 线程一轮处理单个状态机写请求的最大数据量 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其实这个名字已经不太恰当了。因为现在已经调成了 batch size，也就是名字应该是 apply-yield-write-size，含义是单个状态机在 apply 线程持续写入的最大数据量，这是个软限制。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@glorv glorv changed the title tikv: add new config raftstore.apply-yield-msg-size tikv: add new config raftstore.apply-yield-write-size Oct 31, 2022
@glorv
Copy link
Contributor Author

glorv commented Oct 31, 2022

/hold waiting for tikv/tikv#13594 to be merged first.

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2022
Oreoxmt
Oreoxmt reviewed Nov 1, 2022
View reviewed changes
tikv-configuration-file.md Outdated
### `apply-yield-write-size` <span class="version-mark">从 v6.4.0 版本开始引入</span>

+ 单个状态机在 Apply 线程持续写入的最大数据量，这是个软限制。
+ 默认值：32KB
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ 默认值：32KB
+ 默认值：32KiB
+ 单位：

补充单位的信息

dynamic-config.md Outdated
@@ -150,6 +150,7 @@ show warnings;
| raftstore.merge-check-tick-interval | 触发 Merge 完成检查的时间间隔 |
| raftstore.cleanup-import-sst-interval | 触发检查过期 SST 文件的时间间隔 |
| raftstore.local-read-batch-size | 一轮处理读请求的最大个数 |
| raftstore.apply-yield-write-size | 单个状态机在 apply 线程持续写入的最大数据量 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| raftstore.apply-yield-write-size | 单个状态机在 apply 线程持续写入的最大数据量 |
| raftstore.apply-yield-write-size | 单个状态机在 Apply 线程持续写入的最大数据量 |

@Oreoxmt Oreoxmt self-requested a review November 1, 2022 05:21
@glorv
Copy link
Contributor Author

glorv commented Nov 2, 2022

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2022
Oreoxmt
Oreoxmt approved these changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 2, 2022
qiancai
qiancai reviewed Nov 3, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
@glorv @qiancai
Update tikv-configuration-file.md
93ad15c 
Co-authored-by: Grace Cai <qqzczy@126.com>
Oreoxmt
Oreoxmt reviewed Nov 3, 2022
View reviewed changes
dynamic-config.md Outdated
@@ -150,6 +150,7 @@ show warnings;
| raftstore.merge-check-tick-interval | 触发 Merge 完成检查的时间间隔 |
| raftstore.cleanup-import-sst-interval | 触发检查过期 SST 文件的时间间隔 |
| raftstore.local-read-batch-size | 一轮处理读请求的最大个数 |
| raftstore.apply-yield-write-size | 单个状态机在 Apply 线程持续写入的最大数据量 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| raftstore.apply-yield-write-size | 单个状态机在 Apply 线程持续写入的最大数据量 |
| raftstore.apply-yield-write-size | Apply 线程在单个状态机上能持续写入的最大数据量 |

@qiancai qiancai added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Nov 4, 2022
@qiancai
Copy link
Collaborator

qiancai commented Nov 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dc02279

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2022
@ti-chi-bot ti-chi-bot merged commit 458604c into pingcap:master Nov 7, 2022
@glorv glorv deleted the apply-yield-msg-size branch June 21, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@BusyJay BusyJay BusyJay approved these changes

Assignees

@qiancai qiancai

Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.4 This PR/issue applies to TiDB v6.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@glorv @ti-chi-bot @qiancai @BusyJay @Oreoxmt @shichun-0415