Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add doc for flashback database #11915

Merged
merged 6 commits into from
Nov 8, 2022
Merged

sql: add doc for flashback database #11915

merged 6 commits into from
Nov 8, 2022

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Nov 6, 2022 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2022
@qiancai qiancai added translation/doing This PR’s assignee is translating this PR. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. v6.4 This PR/issue applies to TiDB v6.4. labels Nov 6, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Nov 6, 2022
@ran-huang ran-huang requested review from ran-huang and removed request for TomShawn November 7, 2022 02:13
@ran-huang ran-huang added the for-release This PR relates to a TiDB release but does not have a tracked feature. label Nov 7, 2022
ran-huang
ran-huang reviewed Nov 7, 2022
View reviewed changes
sql-statements/sql-statement-flashback-database.md
summary: TiDB 数据库中 FLASHBACK DATABASE 的使用概况。
---

# FLASHBACK DATABASE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是实验特性还是 GA 呢？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GA

sql-statements/sql-statement-flashback-database.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-flashback-database.md Show resolved Hide resolved
sql-statements/sql-statement-flashback-database.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-flashback-database.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-flashback-database.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-flashback-database.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-flashback-database.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-flashback-database.md Outdated Show resolved Hide resolved
Defined2014 and others added 2 commits November 7, 2022 12:06
@Defined2014 @ran-huang
Apply suggestions from code review
091478b 
Co-authored-by: Ran <huangran.alex@gmail.com>
@ran-huang
refine format
158c3c6 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang ran-huang requested a review from hfxsd November 7, 2022 06:48
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 7, 2022
@Defined2014 Defined2014 mentioned this pull request Nov 7, 2022
Merged
14 tasks
hfxsd
hfxsd reviewed Nov 7, 2022
View reviewed changes
sql-statements/sql-statement-flashback-database.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-flashback-database.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-flashback-database.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-flashback-database.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-flashback-database.md Outdated Show resolved Hide resolved
@Defined2014 @hfxsd
Apply suggestions from code review
c2234bf 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 7, 2022
@ran-huang ran-huang mentioned this pull request Nov 8, 2022
Merged
13 tasks
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 8, 2022
bb7133
bb7133 approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9c4c543

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2022
@ti-chi-bot ti-chi-bot merged commit 51af786 into pingcap:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@hfxsd hfxsd hfxsd approved these changes

@xhebox xhebox xhebox approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees

@ran-huang ran-huang

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. for-release This PR relates to a TiDB release but does not have a tracked feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.4 This PR/issue applies to TiDB v6.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Defined2014 @ti-chi-bot @ran-huang @bb7133 @xhebox @hfxsd @qiancai