Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more information to debug TTL #12959

Merged
merged 5 commits into from
Feb 17, 2023
Merged

add more information to debug TTL #12959

merged 5 commits into from
Feb 17, 2023

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Feb 8, 2023

Signed-off-by: YangKeao yangkeao@chunibyo.icu

First-time contributors' checklist

What is changed, added or deleted? (Required)

  1. Add description for some grafana panels.
  2. Add description about the system table used by TTL.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

ref: pingcap/tidb#41155

@YangKeao YangKeao added the v6.6 label Feb 8, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2023
@YangKeao YangKeao changed the title add more information to debug TTl add more information to debug TTL Feb 8, 2023
@TomShawn TomShawn mentioned this pull request Feb 8, 2023
Merged
15 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. for-release This PR relates to a TiDB release but does not have a tracked feature. and removed missing-translation-status This PR does not have translation status info. labels Feb 8, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2023
lcwangchao
lcwangchao reviewed Feb 8, 2023
View reviewed changes
time-to-live.md Outdated Show resolved Hide resolved
grafana-tidb-dashboard.md Outdated Show resolved Hide resolved
@YangKeao YangKeao force-pushed the add-ttl-metrics branch 2 times, most recently from c648d1b to 4ed6617 Compare February 8, 2023 07:58
TomShawn
TomShawn approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

grafana-tidb-dashboard.md Outdated Show resolved Hide resolved
time-to-live.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 9, 2023
SunRunAway
SunRunAway reviewed Feb 14, 2023
View reviewed changes
time-to-live.md Outdated Show resolved Hide resolved
time-to-live.md Outdated Show resolved Hide resolved
@YangKeao
add more information to debug TTl
bd416ce 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 15, 2023
@YangKeao
Copy link
Member Author

Is there anyway to preview this website?

@ran-huang
Copy link
Contributor

Is there anyway to preview this website?

@YangKeao Please clone this repo and follow instructions in readme

ran-huang
ran-huang reviewed Feb 16, 2023
View reviewed changes
grafana-tidb-dashboard.md Outdated Show resolved Hide resolved
time-to-live.md Outdated Show resolved Hide resolved
time-to-live.md Outdated Show resolved Hide resolved
time-to-live.md Outdated Show resolved Hide resolved
time-to-live.md Outdated Show resolved Hide resolved
lcwangchao
lcwangchao reviewed Feb 16, 2023
View reviewed changes
grafana-tidb-dashboard.md Outdated Show resolved Hide resolved
time-to-live.md Outdated Show resolved Hide resolved
time-to-live.md Outdated Show resolved Hide resolved
time-to-live.md Outdated Show resolved Hide resolved
time-to-live.md Outdated Show resolved Hide resolved
@ran-huang ran-huang added translation/doing This PR’s assignee is translating this PR. and removed translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Feb 16, 2023
lcwangchao
lcwangchao reviewed Feb 16, 2023
View reviewed changes
time-to-live.md Outdated Show resolved Hide resolved
@lcwangchao
Copy link
Contributor

使用限制里面的："目前单个表的清理任务同时只能在同一个 TiDB Server 节点运行，这在某些场景下（比如表特别大的情况）可能会产生性能瓶颈。此问题会在后续版本中优化。" 这个是不是也要删除掉了

@YangKeao YangKeao force-pushed the add-ttl-metrics branch 2 times, most recently from 0289176 to 1a3e90e Compare February 16, 2023 06:09
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 16, 2023
@YangKeao
add description to tables and QA
5bc93df 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member Author

/retest

@YangKeao
add description of TTL tables in mysql schema
878e097 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
ran-huang
ran-huang reviewed Feb 16, 2023
View reviewed changes
time-to-live.md Outdated Show resolved Hide resolved
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 16, 2023
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0784970

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 17, 2023
@ti-chi-bot ti-chi-bot merged commit e4828e7 into pingcap:master Feb 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 22, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

@SunRunAway SunRunAway SunRunAway left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees

@YangKeao YangKeao

@ran-huang ran-huang

Labels
for-release This PR relates to a TiDB release but does not have a tracked feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@YangKeao @ti-chi-bot @ran-huang @lcwangchao @SunRunAway @TomShawn