Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: plan cache support subquery #13228

Merged
merged 9 commits into from
Mar 20, 2023
Merged

planner: plan cache support subquery #13228

merged 9 commits into from
Mar 20, 2023

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Mar 1, 2023 •
edited by Oreoxmt
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Starting from v7.0.0, prepared plan cache supports subquery.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 1, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2023
@ti-chi-bot ti-chi-bot requested a review from ran-huang March 1, 2023 06:03
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 1, 2023
@ran-huang ran-huang requested review from TomShawn and removed request for ran-huang March 2, 2023 01:37
@ran-huang ran-huang added the v7.0 label Mar 2, 2023
qw4990
qw4990 reviewed Mar 8, 2023
View reviewed changes
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
@fzzf678 fzzf678 marked this pull request as ready for review March 13, 2023 08:53
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2023
@TomShawn TomShawn added area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Mar 13, 2023
fzzf678
fzzf678 commented Mar 15, 2023
View reviewed changes
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
fzzf678
fzzf678 commented Mar 15, 2023
View reviewed changes
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
fzzf678
fzzf678 commented Mar 15, 2023
View reviewed changes
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
fzzf678
fzzf678 commented Mar 15, 2023
View reviewed changes
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
qw4990
qw4990 approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oreoxmt Oreoxmt assigned Oreoxmt and unassigned TomShawn Mar 16, 2023
@Oreoxmt Oreoxmt removed the request for review from TomShawn March 16, 2023 10:02
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2023
Oreoxmt
Oreoxmt reviewed Mar 16, 2023
View reviewed changes
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2023
@Oreoxmt Oreoxmt requested a review from ran-huang March 16, 2023 10:03
@Oreoxmt Oreoxmt mentioned this pull request Mar 17, 2023
Merged
15 tasks
@Oreoxmt Oreoxmt removed the translation/doing This PR’s assignee is translating this PR. label Mar 17, 2023
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Mar 17, 2023
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. translation/doing This PR’s assignee is translating this PR. labels Mar 17, 2023
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2023
@Oreoxmt Oreoxmt added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Mar 17, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Mar 17, 2023

/remove-status LGT2
/status LGT3

@ti-chi-bot ti-chi-bot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Mar 17, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Mar 20, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 16ea24e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 20, 2023
@ti-chi-bot ti-chi-bot merged commit 37d4562 into pingcap:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@ran-huang ran-huang ran-huang approved these changes

@qw4990 qw4990 qw4990 approved these changes

@chrysan chrysan chrysan approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fzzf678 @ti-chi-bot @Oreoxmt @chrysan @qw4990 @ran-huang @TomShawn