Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: update changefeed scheduler configs #13341

Merged
merged 8 commits into from
Mar 22, 2023
Merged

ticdc: update changefeed scheduler configs #13341

merged 8 commits into from
Mar 22, 2023

Conversation

overvenus
Copy link
Member

First-time contributors' checklist

What is changed, added or deleted? (Required)

update changefeed scheduler configs

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@overvenus
ticdc: update changefeed scheduler configs
b7a4445 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd
  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from hfxsd March 9, 2023 08:36
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2023
@overvenus overvenus mentioned this pull request Mar 10, 2023
Closed
22 tasks
@TomShawn TomShawn added v7.0 area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Mar 10, 2023
@TomShawn
Copy link
Contributor

@overvenus Please invite a tech review. Thanks

hfxsd
hfxsd reviewed Mar 13, 2023
View reviewed changes
ticdc/ticdc-changefeed-config.md Show resolved Hide resolved
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
@overvenus @hfxsd
Apply suggestions from code review
0d20bc9 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@hfxsd hfxsd mentioned this pull request Mar 13, 2023
Merged
15 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 13, 2023
@overvenus @hfxsd
Update ticdc/ticdc-changefeed-config.md
2a64324 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@hfxsd hfxsd requested a review from qiancai March 15, 2023 01:41
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2023
qiancai
qiancai reviewed Mar 15, 2023
View reviewed changes
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
@overvenus
add a note and address comments
5c0e272 
Signed-off-by: Neil Shen <overvenus@gmail.com>
hfxsd
hfxsd reviewed Mar 16, 2023
View reviewed changes
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Mar 16, 2023
View reviewed changes
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
qiancai
qiancai approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM

ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2023
@hfxsd @qiancai
Update ticdc/ticdc-changefeed-config.md
31bbdf2 
Co-authored-by: Grace Cai <qqzczy@126.com>
@hfxsd hfxsd added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Mar 21, 2023
@hfxsd hfxsd requested a review from Frank945946 March 22, 2023 08:49
@hfxsd
Copy link
Collaborator

hfxsd commented Mar 22, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 31bbdf2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2023
@ti-chi-bot ti-chi-bot merged commit 1cd8455 into pingcap:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@Frank945946 Frank945946 Frank945946 approved these changes

@qiancai qiancai qiancai approved these changes

@zhaoxinyu zhaoxinyu zhaoxinyu approved these changes

Assignees

@hfxsd hfxsd

Labels
area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@overvenus @ti-chi-bot @TomShawn @hfxsd @zhaoxinyu @qiancai @Frank945946