Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add description of stale read metrics #14207

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

you06
Copy link
Contributor

@you06 you06 commented Jun 13, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

TiDB v6.5.3 introduces two metrics for Stale Read.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 13, 2023
@Oreoxmt Oreoxmt self-requested a review June 13, 2023 03:29
@Oreoxmt Oreoxmt added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. translation/doing This PR’s assignee is translating this PR. labels Jun 13, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 13, 2023
grafana-tidb-dashboard.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 13, 2023

/verify

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 13, 2023

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 13, 2023
@Oreoxmt Oreoxmt requested a review from qiancai June 13, 2023 03:33
@Oreoxmt Oreoxmt mentioned this pull request Jun 13, 2023
17 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 13, 2023
@Oreoxmt Oreoxmt assigned Oreoxmt and unassigned you06 Jun 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 14, 2023

@Oreoxmt: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 14, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-13 03:33:29.462168675 +0000 UTC m=+56605.876772754: ☑️ agreed by Oreoxmt.
  • 2023-06-14 02:26:41.569232656 +0000 UTC m=+138997.983836734: ☑️ agreed by qiancai.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 14, 2023

/verify

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 14, 2023

/approve
/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 14, 2023
@ti-chi-bot ti-chi-bot bot merged commit 627002e into pingcap:master Jun 14, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #14222.

ran-huang pushed a commit that referenced this pull request Jun 14, 2023
* add description of stale read metrics

Signed-off-by: you06 <you1474600@gmail.com>

* Apply suggestions from code review

---------

Signed-off-by: you06 <you1474600@gmail.com>
Co-authored-by: you06 <you1474600@gmail.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants