Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimizer: add docs for shared cte and explain enhancement #14634

Merged
merged 6 commits into from
Aug 3, 2023
Merged

optimizer: add docs for shared cte and explain enhancement #14634

merged 6 commits into from
Aug 3, 2023

Conversation

winoros
Copy link
Member

@winoros winoros commented Jul 25, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

pingcap/tidb#45252
pingcap/tidb#42296

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 25, 2023
@ran-huang ran-huang added v7.3 This PR/issue applies to TiDB v7.3. translation/doing This PR’s assignee is translating this PR. labels Jul 26, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jul 26, 2023
@Oreoxmt Oreoxmt self-requested a review July 26, 2023 02:42
@Oreoxmt Oreoxmt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 26, 2023

@winoros Could you please invite a tech reviewer? Thanks!

@winoros winoros requested a review from chrysan July 26, 2023 07:01
@Oreoxmt Oreoxmt added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Jul 26, 2023
chrysan
chrysan approved these changes Jul 26, 2023
View reviewed changes
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2023

@chrysan: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Oreoxmt
Oreoxmt reviewed Jul 27, 2023
View reviewed changes
winoros and others added 3 commits July 28, 2023 12:43
@winoros @Oreoxmt
Apply suggestions from code review
f6ae37a 
Co-authored-by: Aolin <aolinz@outlook.com>
@winoros @chrysan
Update explain-walkthrough.md
baaac1d 
Co-authored-by: Xiaoju Wu <wuxiaoju@pingcap.com>
@winoros
address comments
080fcb2
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 28, 2023

@chrysan: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Oreoxmt
Oreoxmt reviewed Jul 31, 2023
View reviewed changes
@Oreoxmt Oreoxmt mentioned this pull request Aug 1, 2023
Merged
16 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 1, 2023
@Oreoxmt Oreoxmt requested a review from hfxsd August 1, 2023 04:44
hfxsd
hfxsd reviewed Aug 1, 2023
View reviewed changes
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 1, 2023
@winoros @hfxsd @Oreoxmt
Apply suggestions from code review
718c2b8 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 1, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-01 06:23:44.606222777 +0000 UTC m=+166508.548571304: ☑️ agreed by hfxsd.
  • 2023-08-01 14:57:49.45381884 +0000 UTC m=+197353.396167370: ☑️ agreed by Oreoxmt.

Oreoxmt
Oreoxmt reviewed Aug 2, 2023
View reviewed changes
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Aug 3, 2023

/approve
/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 3, 2023
@ti-chi-bot ti-chi-bot bot merged commit 814ae55 into pingcap:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@chrysan chrysan chrysan approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.3 This PR/issue applies to TiDB v7.3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@winoros @Oreoxmt @chrysan @hfxsd @ran-huang