Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: refine placement rule in sql docs #15190

Merged
merged 69 commits into from
Nov 15, 2023
Merged

*: refine placement rule in sql docs #15190

merged 69 commits into from
Nov 15, 2023

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Oct 12, 2023 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2023
@nolouch nolouch mentioned this pull request Oct 11, 2023
Closed
33 tasks
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2023
@nolouch nolouch marked this pull request as ready for review October 16, 2023 09:10
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2023
@nolouch nolouch force-pushed the improve-ruleinsql branch 3 times, most recently from 2e0030c to 1db2cac Compare October 16, 2023 09:37
@nolouch
*: refine placement rule in sql
83c5af4 
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch changed the title *: refine placement rule in sql *: refine placement rule in sql docs Oct 16, 2023
@nolouch
fix
58ff756 
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added the v7.5 This PR/issue applies to TiDB v7.5. label Oct 17, 2023
@nolouch
Copy link
Member Author

nolouch commented Oct 17, 2023

PTAL @CabinfeverB @niubell

CabinfeverB
CabinfeverB reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@CabinfeverB CabinfeverB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

统一一下 放置规则 和 放置策略？

placement-rules-in-sql.md Show resolved Hide resolved
placement-rules-in-sql.md Show resolved Hide resolved
placement-rules-in-sql.md Outdated Show resolved Hide resolved
nolouch and others added 3 commits October 17, 2023 15:09
@nolouch @CabinfeverB
Update placement-rules-in-sql.md
e025712 
Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com>
@nolouch
fix
b14461f 
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
fix
13bfbfe 
Signed-off-by: nolouch <nolouch@gmail.com>
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Oct 17, 2023
@Oreoxmt Oreoxmt added the type/enhancement The issue or PR belongs to an enhancement. label Oct 17, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 7, 2023
nolouch and others added 6 commits November 7, 2023 14:55
@nolouch @qiancai
Update placement-rules-in-sql.md
e8b00ac 
Co-authored-by: Grace Cai <qqzczy@126.com>
@nolouch @qiancai
Update placement-rules-in-sql.md
35b7047 
Co-authored-by: Grace Cai <qqzczy@126.com>
@nolouch @qiancai
Update placement-rules-in-sql.md
2c7bc62 
Co-authored-by: Grace Cai <qqzczy@126.com>
@nolouch @qiancai
Update placement-rules-in-sql.md
b1baeaf 
Co-authored-by: Grace Cai <qqzczy@126.com>
@nolouch @qiancai
Update placement-rules-in-sql.md
19be375 
Co-authored-by: Grace Cai <qqzczy@126.com>
@nolouch
address
56251bf 
Signed-off-by: nolouch <nolouch@gmail.com>
qiancai
qiancai reviewed Nov 7, 2023
View reviewed changes
placement-rules-in-sql.md Outdated Show resolved Hide resolved
nolouch and others added 2 commits November 8, 2023 14:09
@nolouch @hfxsd
Update sql-statements/sql-statement-alter-range.md
32865e6 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@nolouch @hfxsd
Update sql-statements/sql-statement-alter-range.md
26c3bb8 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
qiancai
qiancai reviewed Nov 8, 2023
View reviewed changes
placement-rules-in-sql.md Outdated Show resolved Hide resolved
@qiancai qiancai removed the translation/doing This PR’s assignee is translating this PR. label Nov 10, 2023
@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Nov 10, 2023
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Nov 10, 2023
@qiancai
Copy link
Collaborator

qiancai commented Nov 15, 2023

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 15, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 15, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-30 08:03:08.340460607 +0000 UTC m=+2853785.927570737: ☑️ agreed by hfxsd.
  • 2023-11-15 06:23:50.077730098 +0000 UTC m=+4230227.664840243: ☑️ agreed by qiancai.

@ti-chi-bot ti-chi-bot bot merged commit 4bebe5e into pingcap:master Nov 15, 2023
4 of 5 checks passed
@nolouch nolouch deleted the improve-ruleinsql branch November 15, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@lcwangchao lcwangchao Awaiting requested review from lcwangchao

Assignees

@qiancai qiancai

Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement. v7.5 This PR/issue applies to TiDB v7.5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nolouch @qiancai @CabinfeverB @hfxsd @Oreoxmt