Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb-lightning-faq: Add item for copying a schema #15512

Merged
merged 5 commits into from
Nov 30, 2023
Merged

tidb-lightning-faq: Add item for copying a schema #15512

merged 5 commits into from
Nov 30, 2023

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

Add item about copying a schema (both definition and data).

This is sometimes requested for testing/acceptance/etc

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang ran-huang added area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.3 translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement The issue or PR belongs to an enhancement. labels Nov 27, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 27, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 27, 2023
lilin90
lilin90 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-28 07:16:50.74718141 +0000 UTC m=+907039.412407598: ☑️ agreed by lilin90.

@lilin90 lilin90 added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2023
@ran-huang ran-huang added needs-cherry-pick-release-7.4 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Nov 30, 2023
@ran-huang
Copy link
Contributor Author

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit a69bb9a into pingcap:master Nov 30, 2023
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #15574.

This was referenced Nov 30, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #15575.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #15576.

This was referenced Nov 30, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #15577.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15578.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 30, 2023
Merged
15 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 30, 2023
@ti-chi-bot
tidb-lightning-faq: Add item for copying a schema (#15512) (#15578)
a5217ce
ti-chi-bot bot pushed a commit that referenced this pull request Nov 30, 2023
@ti-chi-bot
tidb-lightning-faq: Add item for copying a schema (#15512) (#15576)
399dd35
ti-chi-bot bot pushed a commit that referenced this pull request Nov 30, 2023
@ti-chi-bot
tidb-lightning-faq: Add item for copying a schema (#15512) (#15574)
a0af272
ti-chi-bot bot pushed a commit that referenced this pull request Nov 30, 2023
@ti-chi-bot
tidb-lightning-faq: Add item for copying a schema (#15512) (#15575)
cc6e267
ti-chi-bot bot pushed a commit that referenced this pull request Nov 30, 2023
@ti-chi-bot
tidb-lightning-faq: Add item for copying a schema (#15512) (#15577)
cb75d41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

Assignees
No one assigned
Labels
approved area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ran-huang @ti-chi-bot @lilin90