Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust the recommend value of raft election-timeout in multi dc deployment #16468

Merged
merged 8 commits into from
Feb 22, 2024
Merged

adjust the recommend value of raft election-timeout in multi dc deployment #16468

merged 8 commits into from
Feb 22, 2024

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Jan 31, 2024 •
edited by hfxsd
Loading

…yment

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@glorv glorv requested a review from ran-huang January 31, 2024 09:40
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2024
@glorv glorv requested review from disksing and Connor1996 January 31, 2024 09:41
Connor1996
Connor1996 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 31, 2024

@Connor1996: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@glorv
Copy link
Contributor Author

glorv commented Feb 20, 2024

/cc @ran-huang PTAL

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2024

@glorv: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ran-huang PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. type/cherry-pick-for-release-7.6 This PR is cherry-picked to release-7.6 from a source PR. and removed missing-translation-status This PR does not have translation status info. labels Feb 21, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 21, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-21 03:22:13.837145842 +0000 UTC m=+413822.584768938: ☑️ agreed by hfxsd.

@hfxsd hfxsd self-assigned this Feb 21, 2024
@glorv glorv mentioned this pull request Feb 21, 2024
Merged
18 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 21, 2024
@ti-chi-bot ti-chi-bot bot merged commit 074bd4b into pingcap:master Feb 22, 2024
6 of 7 checks passed
@hfxsd hfxsd added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.6 and removed type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. type/cherry-pick-for-release-7.6 This PR is cherry-picked to release-7.6 from a source PR. labels Feb 22, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #16636.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Feb 22, 2024
@glorv @ti-chi-bot
This is an automated cherry-pick of pingcap#16468
e69d40c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 22, 2024
Merged
18 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Feb 22, 2024
@glorv @ti-chi-bot
adjust the recommend value of raft election-timeout in multi dc deplo…
5785694 
…yment (pingcap#16468)
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 22, 2024
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #16637.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Feb 22, 2024
@glorv @ti-chi-bot
adjust the recommend value of raft election-timeout in multi dc deplo…
222e60e 
…yment (pingcap#16468)
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 22, 2024
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16638.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16639.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Feb 22, 2024
@glorv @ti-chi-bot
adjust the recommend value of raft election-timeout in multi dc deplo…
d718560 
…yment (pingcap#16468)
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 22, 2024
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Feb 22, 2024
@ti-chi-bot
adjust the recommend value of raft election-timeout in multi dc deplo…
4e7c1dd 
…yment (#16468) (#16637)
ti-chi-bot bot pushed a commit that referenced this pull request Feb 22, 2024
@ti-chi-bot
adjust the recommend value of raft election-timeout in multi dc deplo…
aa43f61 
…yment (#16468) (#16639)
ti-chi-bot bot pushed a commit that referenced this pull request Feb 22, 2024
@ti-chi-bot
adjust the recommend value of raft election-timeout in multi dc deplo…
960fd01 
…yment (#16468) (#16638)
ti-chi-bot bot pushed a commit that referenced this pull request Feb 22, 2024
@ti-chi-bot
adjust the recommend value of raft election-timeout in multi dc deplo…
6165d4a 
…yment (#16468) (#16636)
This was referenced Feb 22, 2024
Merged
Merged
Merged
Merged
@glorv glorv deleted the election-timeout branch June 21, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai left review comments

@hfxsd hfxsd hfxsd approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@glorv @hfxsd @ti-chi-bot @Connor1996 @qiancai