Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: update token-limit max value #17365

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

djshow832
Copy link
Contributor

@djshow832 djshow832 commented May 20, 2024

What is changed, added or deleted? (Required)

Close #17195

Set the max value of token-limit to 1048576.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2024
@djshow832 djshow832 requested review from hfxsd and Defined2014 May 20, 2024 02:09
Copy link

ti-chi-bot bot commented May 20, 2024

@Defined2014: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented May 20, 2024

@djshow832 Could you please confirm whether this change applies to v8.2 and later?

@Oreoxmt Oreoxmt added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label May 20, 2024
@Oreoxmt Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label May 20, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 20, 2024
@Oreoxmt Oreoxmt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2024
@djshow832
Copy link
Contributor Author

@djshow832 Could you please confirm whether this change applies to v8.2 and later?

Yes, it applies to v8.2 and later.

@Oreoxmt Oreoxmt added for-release This PR relates to a TiDB release but does not have a tracked feature. v8.2 labels May 20, 2024
@Oreoxmt Oreoxmt removed the request for review from hfxsd May 20, 2024 06:38
@qiancai qiancai self-assigned this May 20, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 11, 2024
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 11, 2024
@Oreoxmt Oreoxmt self-requested a review June 12, 2024 02:54
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 13, 2024
Copy link

ti-chi-bot bot commented Jun 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-11 09:08:26.182983631 +0000 UTC m=+455660.236295556: ☑️ agreed by qiancai.
  • 2024-06-13 02:20:35.891371936 +0000 UTC m=+603989.944683852: ☑️ agreed by Oreoxmt.

@qiancai
Copy link
Collaborator

qiancai commented Jun 27, 2024

/approve

@qiancai
Copy link
Collaborator

qiancai commented Jun 27, 2024

/approve

Copy link

ti-chi-bot bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 27, 2024
@qiancai qiancai removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 99f48db into pingcap:master Jun 27, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

token-limit 配置项最大值不合理
5 participants