Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd: GA active follower #19025

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Nov 7, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2024
@okJiang okJiang mentioned this pull request Nov 8, 2024
17 tasks
@Oreoxmt Oreoxmt self-assigned this Nov 8, 2024
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.5 labels Nov 8, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 8, 2024
@Oreoxmt Oreoxmt added missing-translation-status This PR does not have translation status info. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 8, 2024
@Oreoxmt Oreoxmt self-requested a review November 8, 2024 03:13
Copy link

ti-chi-bot bot commented Nov 11, 2024

@nolouch: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 13, 2024

/remove-label missing-translation-status

Copy link

ti-chi-bot bot commented Nov 13, 2024

@Oreoxmt: The label(s) missing-translation-status cannot be applied. These labels are supported: 2024-tidb-docs-dash, contribution, first-time-contributor, for-future-release, good first issue, hacktoberfest-accepted, Hacktoberfest, help wanted, needs-cherry-pick-master, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-cherry-pick-release-8.1, needs-cherry-pick-release-8.5, needs-cherry-pick-release-8.2, needs-cherry-pick-release-8.3, needs-cherry-pick-release-8.4, question, requires-followup, requires-version-specific-changes, special-week, website.

In response to this:

/remove-label missing-translation-status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 13, 2024
@Oreoxmt Oreoxmt removed the missing-translation-status This PR does not have translation status info. label Nov 13, 2024
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 19, 2024

/cc @qiancai

@ti-chi-bot ti-chi-bot bot requested a review from qiancai November 19, 2024 03:00
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 20, 2024
Copy link

ti-chi-bot bot commented Nov 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-13 09:19:02.43431775 +0000 UTC m=+434304.625186747: ☑️ agreed by Oreoxmt.
  • 2024-11-20 06:48:34.959691915 +0000 UTC m=+14302.579346430: ☑️ agreed by qiancai.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 22, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2024
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 22, 2024

/approve

Copy link

ti-chi-bot bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit ad37fe0 into pingcap:master Nov 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants