Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc for APPROX_DISTINCT_COUNT aggregate function #19732

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Add doc for APPROX_DISTINCT_COUNT aggregate function #19732

merged 7 commits into from
Feb 12, 2025

Conversation

xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Feb 8, 2025 •
edited by qiancai
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2025
@qiancai qiancai self-assigned this Feb 8, 2025
@qiancai qiancai self-requested a review February 8, 2025 01:56
xzhangxian1008 and others added 3 commits February 12, 2025 10:53
@xzhangxian1008 @qiancai
Update functions-and-operators/aggregate-group-by-functions.md
a460ab0 
Co-authored-by: Grace Cai <qqzczy@126.com>
@xzhangxian1008 @qiancai
Update functions-and-operators/aggregate-group-by-functions.md
6a8324b 
Co-authored-by: Grace Cai <qqzczy@126.com>
@xzhangxian1008 @qiancai
Update functions-and-operators/aggregate-group-by-functions.md
d9e4832 
Co-authored-by: Grace Cai <qqzczy@126.com>
@qiancai qiancai added translation/from-docs This PR is translated from a PR in pingcap/docs. and removed missing-translation-status This PR does not have translation status info. labels Feb 12, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 12, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-12 03:33:19.081400171 +0000 UTC m=+413841.477622234: ☑️ agreed by qiancai.

@qiancai qiancai added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Feb 12, 2025
@qiancai
Copy link
Collaborator

qiancai commented Feb 12, 2025

/approve

@qiancai qiancai added the lgtm label Feb 12, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 12, 2025
@ti-chi-bot ti-chi-bot bot merged commit 6f47cea into pingcap:master Feb 12, 2025
6 of 7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #19776.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 12, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #19777.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 12, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19778.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 12, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #19779.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 12, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #19780.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 12, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19781.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 12, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #19782.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 12, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #19783.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 12, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #19784.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 12, 2025
Merged
16 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025
@ti-chi-bot
Add doc for APPROX_DISTINCT_COUNT aggregate function (#19732) (#19780)
d589ac9
ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025
@ti-chi-bot
Add doc for APPROX_DISTINCT_COUNT aggregate function (#19732) (#19781)
98471f6
ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025
@ti-chi-bot
Add doc for APPROX_DISTINCT_COUNT aggregate function (#19732) (#19779)
762eda0
ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025
@ti-chi-bot
Add doc for APPROX_DISTINCT_COUNT aggregate function (#19732) (#19782)
ab4fcbd
ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025
@ti-chi-bot
Add doc for APPROX_DISTINCT_COUNT aggregate function (#19732) (#19784)
9602cc9
ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025
@ti-chi-bot
Add doc for APPROX_DISTINCT_COUNT aggregate function (#19732) (#19777)
956084d
ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025
@ti-chi-bot
Add doc for APPROX_DISTINCT_COUNT aggregate function (#19732) (#19778)
2f4ea8e
ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025
@ti-chi-bot
Add doc for APPROX_DISTINCT_COUNT aggregate function (#19732) (#19776)
cbda9d0
ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025
@ti-chi-bot
Add doc for APPROX_DISTINCT_COUNT aggregate function (#19732) (#19783)
dc1208e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

Assignees

@qiancai qiancai

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xzhangxian1008 @qiancai @ti-chi-bot