Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stale read: update the description of tidb_external_ts #20134

Merged
merged 1 commit into from
Apr 10, 2025
Merged

stale read: update the description of tidb_external_ts #20134

merged 1 commit into from
Apr 10, 2025

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Mar 28, 2025 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs This PR is translated from a PR in pingcap/docs. ONCALL Relates to documentation oncall. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Mar 28, 2025
@Oreoxmt Oreoxmt self-assigned this Mar 28, 2025
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2025
@Oreoxmt Oreoxmt requested a review from YangKeao March 28, 2025 07:09
@Oreoxmt Oreoxmt mentioned this pull request Mar 28, 2025
Closed
YangKeao
YangKeao approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 8, 2025

@YangKeao: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd self-requested a review April 9, 2025 03:50
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 9, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-09 09:58:56.66267748 +0000 UTC m=+2250430.346913576: ☑️ agreed by hfxsd.

@Oreoxmt Oreoxmt added the lgtm label Apr 10, 2025
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Apr 10, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 10, 2025
@ti-chi-bot ti-chi-bot bot merged commit 915b197 into pingcap:master Apr 10, 2025
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #20168.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 10, 2025
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #20169.

This was referenced Apr 10, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20170.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #20171.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 10, 2025
Merged
15 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Apr 10, 2025
@ti-chi-bot
stale read: update the description of tidb_external_ts (#20134) (#20171)
bfcfe3f
ti-chi-bot bot pushed a commit that referenced this pull request Apr 10, 2025
@ti-chi-bot
stale read: update the description of tidb_external_ts (#20134) (#20168)
3e5bdec
ti-chi-bot bot pushed a commit that referenced this pull request Apr 10, 2025
@ti-chi-bot
stale read: update the description of tidb_external_ts (#20134) (#20169)
a1ae271
ti-chi-bot bot pushed a commit that referenced this pull request Apr 10, 2025
@ti-chi-bot
stale read: update the description of tidb_external_ts (#20134) (#20170)
2e63890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Oreoxmt @ti-chi-bot @YangKeao @hfxsd