Skip to content

br: pitr filter feature release doc #20450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 15, 2025
Merged

br: pitr filter feature release doc #20450

merged 6 commits into from
Aug 15, 2025

Conversation

Tristan1900
Copy link
Contributor

@Tristan1900 Tristan1900 commented Jun 3, 2025 •
edited by lilin90
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Tristan1900
br: pitr filter feature release doc
7d7cc80 
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 3, 2025
@Tristan1900 Tristan1900 mentioned this pull request Jun 3, 2025
Merged
16 tasks
@lilin90 lilin90 added the translation/from-docs This PR is translated from a PR in pingcap/docs. label Jun 4, 2025
@lilin90 lilin90 self-assigned this Jun 4, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 4, 2025
@lilin90 lilin90 requested review from Copilot and lilin90 June 4, 2025 02:46
@lilin90 lilin90 added the v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2. label Jun 4, 2025
Copilot
Copilot AI reviewed Jun 4, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the BR documentation by introducing a new section on using filters during PITR operations, as well as adding a new section on concurrent recovery operations.

  • Introduces step-by-step instructions and examples for using filters to restore specific databases or tables.
  • Adds documentation on how to perform concurrent PITR operations with sample commands and important notes regarding usage limitations.
Comments suppressed due to low confidence (1)

br/br-pitr-manual.md:573

  • [nitpick] Including an example or additional details to clarify what constitutes overlapping data sets could help users avoid potential misuse of concurrent PITR operations.
> - 每个并发恢复操作必须针对不同的数据库或非重叠的表集合。尝试并发恢复重叠数据集将导致错误。

br/br-pitr-manual.md Outdated
### 进行中的日志备份与快照恢复的兼容性
从 v9.0.0 开始，当存在日志备份任务时，如果**同时满足**以下条件，则可以正常进行快照恢复 (`br restore [full|database|table]`)，并且恢复的数据可以被进行中的日志备份（下称“日志备份”）正常记录：
从 v9.0.0 开始，当存在日志备份任务时，如果**同时满足**以下条件，则可以正常进行快照恢复 (`br restore [full|database|table]`)，并且恢复的数据可以被进行中的日志备份（下称"日志备份"）正常记录：
Copy link

Copilot AI Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider aligning the style of quotation marks used for '日志备份' consistently throughout the document to enhance clarity.

Copilot uses AI. Check for mistakes.

@lilin90 lilin90 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2025
lilin90
lilin90 reviewed Jun 16, 2025
View reviewed changes
@lilin90 lilin90 requested a review from hfxsd June 16, 2025 08:57
@Tristan1900 @lilin90
Apply suggestions from code review
762ba0f 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@Tristan1900
Copy link
Contributor Author

@lilin90 thanks for the detailed review!

@Tristan1900
add abort command
6a83151 
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
hfxsd
hfxsd reviewed Jul 3, 2025
View reviewed changes
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 3, 2025
@Tristan1900 @hfxsd
Update br/br-pitr-manual.md
3052089 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
lilin90
lilin90 reviewed Jul 14, 2025
View reviewed changes
lilin90
lilin90 approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 14, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-03 03:09:09.321699061 +0000 UTC m=+1537202.044878028: ☑️ agreed by hfxsd.
  • 2025-07-14 05:45:40.65477465 +0000 UTC m=+2496993.377953633: ☑️ agreed by lilin90.

@Tristan1900
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 14, 2025

@Leavrth: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lilin90
lilin90 reviewed Aug 15, 2025
View reviewed changes
@lilin90
Copy link
Member

lilin90 commented Aug 15, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 15, 2025
@ti-chi-bot ti-chi-bot bot merged commit 937be29 into pingcap:master Aug 15, 2025
7 checks passed
@lilin90 lilin90 mentioned this pull request Sep 16, 2025
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

Copilot code review Copilot Copilot left review comments

@hfxsd hfxsd hfxsd approved these changes

@Leavrth Leavrth Leavrth approved these changes

Assignees

@lilin90 lilin90

Labels

approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Tristan1900 @lilin90 @hfxsd @Leavrth