Skip to content

Conversation

v01dstar
Copy link
Contributor

@v01dstar v01dstar commented Jul 29, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the contribution This PR is from a community contributor. label Jul 29, 2025
Copy link

ti-chi-bot bot commented Jul 29, 2025

Hi @v01dstar. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 29, 2025
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@v01dstar
Copy link
Contributor Author

/cc @Connor1996

@ti-chi-bot ti-chi-bot bot requested a review from Connor1996 July 29, 2025 06:19
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 7, 2025
@v01dstar
Copy link
Contributor Author

v01dstar commented Aug 8, 2025

/ok-to-test

Copy link

ti-chi-bot bot commented Aug 8, 2025

@v01dstar: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@v01dstar
Copy link
Contributor Author

v01dstar commented Aug 8, 2025

/cc @Oreoxmt

@ti-chi-bot ti-chi-bot bot requested a review from Oreoxmt August 8, 2025 05:16
@Oreoxmt Oreoxmt self-assigned this Aug 8, 2025
@Oreoxmt Oreoxmt added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. for-release This PR relates to a TiDB release but does not have a tracked feature. v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2. translation/doing This PR’s assignee is translating this PR. labels Aug 8, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Aug 8, 2025
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Aug 8, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Aug 8, 2025
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Aug 8, 2025

@v01dstar This PR removes the following TiKV configuration items:

  • region-compact-check-interval
  • region-compact-check-step
  • region-compact-min-tombstones
  • region-compact-tombstones-percent
  • region-compact-min-redundant-rows
  • region-compact-redundant-rows-percent

If these configuration items are deprecated starting from v7.5.7 or v9.0.0, they should be marked as deprecated in the documentation rather than deleted. Typically, we deprecate a config in one release and remove it in a later release.

If these items have already been removed from the codebase, it is appropriate to delete them from the configuration documentation. In that case, please also add corresponding release notes https://github.com/pingcap/docs-cn/pull/20705/files#diff-3ff8ef1f5dfa6d9aa8e12f68615eefd2c22f53ca43465a5efee9e2d066c597f3R16 to document this compatibility change.

Additionally, consider adding a general note to help users understand the transition. For example:

This configuration item has been migrated from raftstore.region-compact-check-interval to gc.auto-compaction.check-interval. Starting from v7.5.7 and v9.0.0, raftstore.region-compact-check-interval no longer takes effect.

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
Copy link

ti-chi-bot bot commented Aug 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oreoxmt. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2025
v01dstar and others added 12 commits August 21, 2025 23:40
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 22, 2025
Copy link

ti-chi-bot bot commented Aug 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-07 02:27:35.838059211 +0000 UTC m=+494365.980820376: ☑️ agreed by overvenus.
  • 2025-08-22 06:48:38.644241901 +0000 UTC m=+595326.587417417: ☑️ agreed by Oreoxmt.

@Oreoxmt Oreoxmt changed the title Update auto compaction config tikv: update auto compaction config Aug 26, 2025
@Oreoxmt Oreoxmt added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 26, 2025
@Oreoxmt Oreoxmt removed the translation/doing This PR’s assignee is translating this PR. label Aug 26, 2025
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

| gc.auto-compaction.tombstone-num-threshold | 触发 TiKV 自动 (RocksDB) compaction 需要的 RocksDB tombstone 个数 |
| gc.auto-compaction.tombstone-percent-threshold | 触发 TiKV 自动 (RocksDB) compaction 需要的 RocksDB tombstone 所占比例 |
| gc.auto-compaction.redundant-rows-threshold | 触发 TiKV 自动 (RocksDB) compaction 需要的冗余的 MVCC 数据行数 |
| gc.auto-compaction.redundant-rows-percent-threshold | 触发 TiKV 自动 (RocksDB) compaction 需要的冗余的 MVCC 数据行数所占比例 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L188~L191, RocksDB 加上括号不太容易理解,可以去掉括号,或者直接去掉 (RocksDB) 吗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

取决于读者是谁,如果是懂 tikv 的,加上可能更好,不懂的话,他应该不会看这些参数吧。

v01dstar and others added 8 commits August 26, 2025 10:26
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants