-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: update explain
results
#2548
Conversation
@LittleFall Please sign the CLA and involve a technical review, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
要在这个 PR 中把整个阅读执行计划部分都用 《TiDB in Action》 中的内容更新一下吗?对了,explain for connection
部分也需要介绍,最好也在 《TiDB in Action》中把这部分内容加上。
整合了一下,PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content in reference/performance/understanding-the-query-execution-plan.md
is too long. We'd better to split it into several small sections.
Maybe we can organize the content like this:
file 1: EXPLAIN Basics, covered in https://pingcap.com/docs-cn/stable/reference/sql/statements/explain/#explain
file 2: EXPLAIN FOR Connection, covered in https://pingcap.com/docs-cn/stable/reference/sql/statements/explain-analyze/
file 3: EXPLAIN ANALYZE Extension, not covered in https://pingcap.com/docs-cn/stable/reference/sql/statements/explain/, this doc need to be updated.
file 4: How to read the output of `EXPLAIN`, should be covered in this file
file 5: How to read the output of `EXPLAIN ANALYZE`, maybe we can use another file to cover this topic.
有几个问题
调整了一下这些文件的结构,可能会比较清晰并且最长的文件看起来短一点。 explain.md:
explain-analyze.md:
understanding-the-query-execution-plan.md
PTAL |
@LittleFall 可以,这种格式会合理很多。我们需要尽量确保每个独立的文档阅读时间不超过 10 分钟。 |
reference/performance/understanding-the-query-execution-plan.md
Outdated
Show resolved
Hide resolved
reference/performance/understanding-the-query-execution-plan.md
Outdated
Show resolved
Hide resolved
reference/performance/understanding-the-query-execution-plan.md
Outdated
Show resolved
Hide resolved
reference/performance/understanding-the-query-execution-plan.md
Outdated
Show resolved
Hide resolved
@zz-jason, @winoros, @lzmhhh123, @ran-huang, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Co-Authored-By: Ran <huangran@pingcap.com>
@zz-jason, @winoros, @lzmhhh123, @ran-huang, PTAL. |
@LittleFall, please update your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@LittleFall please resolve the code conflict, thanks. |
* Modify explain result. * Update with tidb-in-action. * Reorder statements. * Fix multi \n bug. * Apply suggestions from code review Co-Authored-By: Ran <huangran@pingcap.com> * Refine some typo. * Refine article structure. * Remove useless "`". * Update reference/sql/statements/explain.md Co-Authored-By: Ran <huangran@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com>
cherry pick to release-4.0 in PR #2865 |
> **注意:** | ||
> | ||
> 目前 TiDB 的 IndexMerge 特性在 4.0 RC 版本中默认关闭,同时 4.0 中的 IndexMerge 目前支持的场景仅限于析取范式(or 连接的表达式),对合取范式(and 连接的表达式)将在之后的版本中支持。 | ||
> 开启 IndexMerge 特性,可通过在客户端中设置 session 或者 global 变量完成:`set @@tidb_enable_index_merge = 1;` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LittleFall 这里“目前...中支持”要与“开启 IndexMerge 特性这一句中间空一行,不然两行实际在显示时显示为一行~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
学习了,我之后一块改一下
* Modify explain result. * Update with tidb-in-action. * Reorder statements. * Fix multi \n bug. * Apply suggestions from code review Co-Authored-By: Ran <huangran@pingcap.com> * Refine some typo. * Refine article structure. * Remove useless "`". * Update reference/sql/statements/explain.md Co-Authored-By: Ran <huangran@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com>
What is changed, added or deleted? (Required)
Update statement of
EXPLAIN
with tidb-in-action.Update explain result with current result.
Which TiDB version(s) do your changes apply to? (Required)
master
What is the related PR or file link(s)?