Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: add a missing item #4758

Merged
merged 2 commits into from
Nov 2, 2020
Merged

lightning: add a missing item #4758

merged 2 commits into from
Nov 2, 2020

Conversation

lance6716
Copy link
Contributor

What is changed, added or deleted? (Required)

header configuration is missing

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@TomShawn TomShawn requested a review from overvenus October 30, 2020 02:40
@TomShawn TomShawn added needs-cherry-pick-3.1 size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Oct 30, 2020
@ti-srebot
Copy link
Contributor

@overvenus, PTAL.

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2020
@overvenus
Copy link
Member

LGTM

TomShawn
TomShawn approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 2, 2020
@TomShawn TomShawn merged commit b2ff26c into pingcap:master Nov 2, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Nov 2, 2020
@lance6716 @ti-srebot
cherry pick pingcap#4758 to release-2.1
c6dbd43 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 2, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #4775

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Nov 2, 2020
@lance6716 @ti-srebot
cherry pick pingcap#4758 to release-3.0
f8a4dd7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 2, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #4776

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Nov 2, 2020
@lance6716 @ti-srebot
cherry pick pingcap#4758 to release-3.1
07edd1e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 2, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #4777

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Nov 2, 2020
@lance6716 @ti-srebot
cherry pick pingcap#4758 to release-4.0
ce09baa 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 2, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4778

TomShawn pushed a commit that referenced this pull request Nov 2, 2020
@ti-srebot @lance6716
cherry pick #4758 to release-4.0 (#4778)
4a5f814 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: lance6716 <lance6716@gmail.com>
TomShawn pushed a commit that referenced this pull request Nov 2, 2020
@ti-srebot @lance6716
cherry pick #4758 to release-3.1 (#4777)
eb32342 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: lance6716 <lance6716@gmail.com>
TomShawn pushed a commit that referenced this pull request Nov 2, 2020
@ti-srebot @lance6716
cherry pick #4758 to release-2.1 (#4775)
237f073 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: lance6716 <lance6716@gmail.com>
TomShawn pushed a commit that referenced this pull request Nov 2, 2020
@ti-srebot @lance6716
cherry pick #4758 to release-3.0 (#4776)
34ccd3e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: lance6716 <lance6716@gmail.com>
@Joyinqin
Copy link
Contributor

Joyinqin commented Nov 2, 2020

/label translation/no-need

@ti-srebot ti-srebot added the translation/no-need No need to translate this PR. label Nov 2, 2020
@Joyinqin
Copy link
Contributor

Joyinqin commented Nov 2, 2020

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR’s assignee is translating this PR. label Nov 2, 2020
@Joyinqin Joyinqin removed their assignment Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@TomShawn TomShawn TomShawn approved these changes

@overvenus overvenus overvenus approved these changes

Assignees
No one assigned
Labels
size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lance6716 @ti-srebot @overvenus @Joyinqin @TomShawn