Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contributing guide: add glossary link (#4756) #4768

Merged
merged 1 commit into from
Nov 2, 2020
Merged

contributing guide: add glossary link (#4756) #4768

merged 1 commit into from
Nov 2, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #4756 to release-3.1

What is changed, added or deleted? (Required)

Add the glossary link to the resources section.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@CharLotteiu @ti-srebot
cherry pick pingcap#4756 to release-3.1
07487c9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 2, 2020
Merged
9 tasks
@ti-srebot ti-srebot added status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR. labels Nov 2, 2020
lilin90
lilin90 approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2020
@lilin90 lilin90 merged commit 2561f9b into pingcap:release-3.1 Nov 2, 2020
@lilin90 lilin90 deleted the release-3.1-9a01ee917a09 branch November 2, 2020 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@yikeke yikeke Awaiting requested review from yikeke

Assignees

@CharLotteiu CharLotteiu

Labels
status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @lilin90 @CharLotteiu