Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

information-schema: add client errors docs #5983

Merged
merged 19 commits into from
Apr 7, 2021
Merged

information-schema: add client errors docs #5983

merged 19 commits into from
Apr 7, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Apr 7, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

This adds docs for pingcap/tidb#22382

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2021
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 7, 2021

/label v5.0
/laebl needs-cherry-pick-5.0
/translation from-docs

@ti-chi-bot ti-chi-bot added translation/from-docs This PR is translated from a PR in pingcap/docs. v5.0 This PR/issue applies to TiDB v5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 7, 2021
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 7, 2021

/label needs-cherry-pick-5.0

@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 7, 2021

/cc @djshow832 @TomShawn

@Joyinqin Joyinqin marked this pull request as ready for review April 7, 2021 09:24
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2021
Joyinqin
Joyinqin commented Apr 7, 2021
View reviewed changes
information-schema/client-errors-summary-global.md Outdated
summary: 了解 information_schema 表 `CLIENT_ERRORS_SUMMARY_GLOBAL`。
---

# CLIENT_ERROR_SUMMARY_GLOBAL
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文此处需要修改

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改：pingcap/docs#5251

@TomShawn
Copy link
Contributor

TomShawn commented Apr 7, 2021

/cc @bb7133

@ti-chi-bot ti-chi-bot requested a review from bb7133 April 7, 2021 09:37
djshow832
djshow832 reviewed Apr 7, 2021
View reviewed changes
information-schema/client-errors-summary-by-host.md Outdated Show resolved Hide resolved
information-schema/client-errors-summary-by-host.md Outdated Show resolved Hide resolved
information-schema/client-errors-summary-by-user.md Outdated Show resolved Hide resolved
information-schema/client-errors-summary-by-user.md Outdated Show resolved Hide resolved
information-schema/client-errors-summary-global.md Outdated
* 权限错误。
* 表不存在。

MySQL 服务器协议会返回以上错误到客户端，此时应用程序应在客户端采取适当操作。information_schema 表 `CLIENT_ERRORS_SUMMARY_GLOBAL` 提供了一种高级概述，在应用程序无法正确处理（或记录）TiDB 服务器返回的错误的情况下很有用。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

information-schema/client-errors-summary-global.md Outdated
Comment on lines 43 to 44
* `ERROR_NUMBER`：返回的与 MySQL 兼容的错误编号。
* `ERROR_MESSAGE`：与错误编号相匹配的错误信息（以预准备语句形式）。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@TomShawn
Copy link
Contributor

TomShawn commented Apr 7, 2021

/uncc @TomShawn
/cc @lilin90

@ti-chi-bot ti-chi-bot requested review from lilin90 and removed request for TomShawn April 7, 2021 10:13
@Joyinqin @djshow832
Apply suggestions from code review
e7214f6 
Co-authored-by: djshow832 <zhangming@pingcap.com>
@djshow832
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@djshow832: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

lilin90
lilin90 reviewed Apr 7, 2021
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only added comments to information-schema/client-errors-summary-by-host.md, but since the other two files have almost the same description, please also update client-errors-summary-by-user.md and client-errors-summary-global.md.

information-schema/client-errors-summary-by-host.md Outdated Show resolved Hide resolved
information-schema/client-errors-summary-by-host.md Outdated Show resolved Hide resolved
information-schema/client-errors-summary-by-host.md Outdated Show resolved Hide resolved
information-schema/client-errors-summary-by-host.md Outdated Show resolved Hide resolved
information-schema/client-errors-summary-by-host.md Outdated Show resolved Hide resolved
@lilin90
Copy link
Member

lilin90 commented Apr 7, 2021

/status require-change

@ti-chi-bot ti-chi-bot added the status/require-change Needs the author to address comments. label Apr 7, 2021
Joyinqin and others added 4 commits April 7, 2021 20:17
@Joyinqin @lilin90
Apply suggestions from code review
20c1279 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@Joyinqin @lilin90
Apply suggestions from code review
b356d9b 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@Joyinqin
update docs
ce25842
@Joyinqin
Merge branch 'add-is-client-errors' of https://github.com/Joyinqin/do…
fc29071 
…cs-cn into add-is-client-errors
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2021
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 7, 2021

@lilin90, @TomShawn PTAL again, thx~

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • yikeke

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2021
@yikeke
Copy link
Contributor

yikeke commented Apr 7, 2021

/merge

@ti-chi-bot
Copy link
Member

@yikeke: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@yikeke
Copy link
Contributor

yikeke commented Apr 7, 2021

/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 7, 2021
@yikeke
Copy link
Contributor

yikeke commented Apr 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ad33bdb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2021
@ti-chi-bot ti-chi-bot merged commit fc92603 into pingcap:master Apr 7, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 7, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5983 to release-5.0
e61e617 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 7, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5990

ti-chi-bot pushed a commit that referenced this pull request Apr 7, 2021
@ti-srebot
information-schema: add client errors docs (#5983) (#5990)
dfff763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@lilin90 lilin90 lilin90 left review comments

@djshow832 djshow832 djshow832 left review comments

@yikeke yikeke yikeke approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. status/require-change Needs the author to address comments. translation/from-docs This PR is translated from a PR in pingcap/docs. v5.0 This PR/issue applies to TiDB v5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Joyinqin @TomShawn @djshow832 @ti-chi-bot @lilin90 @yikeke @ti-srebot