Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct a tikv config name #6073

Merged
merged 1 commit into from
Apr 22, 2021
Merged

correct a tikv config name #6073

merged 1 commit into from
Apr 22, 2021

Conversation

loosoo
Copy link

@loosoo loosoo commented Apr 20, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

ttl-poll-check-interval -> ttl-check-poll-interval
mysql> show config; | tikv | 10.186.1.1:20160 | storage.ttl-check-poll-interval | 12h

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

@loosoo
Update tikv-configuration-file.md
21fe25a 
mysql> show config;
| tikv | 10.186.1.1:20160 | storage.ttl-check-poll-interval                                      | 12h
@CLAassistant
Copy link

CLAassistant commented Apr 20, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Apr 20, 2021
@ti-chi-bot
Copy link
Member

Welcome @deanglc!

It looks like this is your first PR to pingcap/docs-cn 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs-cn. 😃

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 20, 2021
@TomShawn
Copy link
Contributor

/cc @sticnarf

@TomShawn
Copy link
Contributor

/translation doing
/assign Joyinqin
/status PTAL
/label needs-cherry-pick-4.0
/label needs-cherry-pick-master

@ti-chi-bot ti-chi-bot added translation/doing This PR’s assignee is translating this PR. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 needs-cherry-pick-master Should cherry pick this PR to master branch. and removed missing-translation-status This PR does not have translation status info. labels Apr 20, 2021
@loosoo loosoo mentioned this pull request Apr 20, 2021
Merged
7 tasks
@TomShawn
Copy link
Contributor

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 20, 2021
@TomShawn
Copy link
Contributor

/unassign Joyinqin
/assign @deanglc

@ti-chi-bot ti-chi-bot assigned loosoo and unassigned Joyinqin Apr 20, 2021
sticnarf
sticnarf approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@sticnarf: /lgtm is only allowed for the reviewers in list.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/retitle correct a tikv config name

@ti-chi-bot ti-chi-bot changed the title Update tikv-configuration-file.md correct a tikv config name Apr 22, 2021
@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 22, 2021
@TomShawn
Copy link
Contributor

/sig transaction docs

@ti-chi-bot ti-chi-bot added area/transaction Indicates that the Issue or PR belongs to the area of transaction. sig/docs Indicates that the Issue or PR belongs to the docs SIG. labels Apr 22, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 21fe25a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2021
@ti-chi-bot ti-chi-bot merged commit f3e2aa2 into pingcap:release-5.0 Apr 22, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 22, 2021
@loosoo @ti-srebot
cherry pick pingcap#6073 to release-4.0
faedae0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
This was referenced Apr 22, 2021
Closed
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #6111

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 22, 2021
@loosoo @ti-srebot
cherry pick pingcap#6073 to master
ca89c0c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 22, 2021
Merged
7 tasks
@ti-srebot
Copy link
Contributor

cherry pick to master in PR #6112

@TomShawn
Copy link
Contributor

/remove-label needs-cherry-pick-4.0

@ti-srebot ti-srebot mentioned this pull request Apr 22, 2021
Merged
7 tasks
ti-chi-bot pushed a commit that referenced this pull request Apr 22, 2021
@ti-srebot
correct a tikv config name (#6073) (#6112)
56a01d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sticnarf sticnarf sticnarf approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@loosoo loosoo

Labels
area/transaction Indicates that the Issue or PR belongs to the area of transaction. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-master Should cherry pick this PR to master branch. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@loosoo @CLAassistant @ti-chi-bot @TomShawn @ti-srebot @sticnarf @Joyinqin