Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docs for enforce mpp #6250

Merged
merged 27 commits into from
Jun 18, 2021
Merged

add docs for enforce mpp #6250

merged 27 commits into from
Jun 18, 2021

Conversation

LittleFall
Copy link
Contributor

@LittleFall LittleFall commented May 12, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

add docs for enforce mpp

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)

don't need cherry-pick now

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 12, 2021 11:25
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2021
@LittleFall
Copy link
Contributor Author

/cc @hanfei1991

@TomShawn TomShawn added for-future-release This PR only applies to master for now and might cherry-pick to a future release. translation/doing This PR’s assignee is translating this PR. labels May 13, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label May 13, 2021
TomShawn
TomShawn reviewed May 18, 2021
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed May 18, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments

tiflash/use-tiflash.md Outdated Show resolved Hide resolved
tiflash/use-tiflash.md Outdated Show resolved Hide resolved
tiflash/use-tiflash.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2021
@LittleFall LittleFall marked this pull request as draft May 31, 2021 11:46
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2021
@qiancai qiancai added the v5.1 This PR/issue applies to TiDB v5.1. label May 31, 2021
@qiancai
Copy link
Collaborator

qiancai commented May 31, 2021

According to @LittleFall, the changes of this PR are for v5.1 and the changes are still draft so not ready for review.

@TomShawn
Copy link
Contributor

TomShawn commented Jun 3, 2021

@LittleFall Any update?

@LittleFall LittleFall marked this pull request as ready for review June 15, 2021 11:02
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2021
LittleFall and others added 3 commits June 15, 2021 19:24
@LittleFall @TomShawn
Update system-variables.md
1928f22 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@LittleFall @TomShawn
Update tiflash/use-tiflash.md
15ef1a9 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@LittleFall @TomShawn
Update tiflash/use-tiflash.md
34b11d6 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
LittleFall and others added 10 commits June 18, 2021 00:57
@LittleFall @TomShawn
Update tiflash/use-tiflash.md
dddde1d 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@LittleFall @TomShawn
Update tiflash/use-tiflash.md
37c9bcd 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@LittleFall @TomShawn
Update tiflash/use-tiflash.md
8497498 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@LittleFall @TomShawn
Update tiflash/use-tiflash.md
316d2c1 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@LittleFall @TomShawn
Update tiflash/use-tiflash.md
1a0c22f 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@LittleFall @TomShawn
Update tiflash/use-tiflash.md
db08264 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@LittleFall @TomShawn
Update tiflash/use-tiflash.md
da03311 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@LittleFall @TomShawn
Update tiflash/use-tiflash.md
e99bae5 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@LittleFall @TomShawn
Update tiflash/use-tiflash.md
dc17882 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@LittleFall
Update system-variables.md
8cbf4b2
@LittleFall LittleFall requested a review from TomShawn June 18, 2021 04:21
TomShawn
TomShawn approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 18, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 18, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8cbf4b2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@ti-chi-bot ti-chi-bot merged commit a5fd0f7 into pingcap:master Jun 18, 2021
@TomShawn TomShawn assigned Joyinqin and unassigned Liuxiaozhen12 Jun 18, 2021
@Joyinqin Joyinqin mentioned this pull request Jun 18, 2021
Merged
12 tasks
@Joyinqin
Copy link
Contributor

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 18, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 22, 2021
Merged
12 tasks
@LittleFall LittleFall deleted the patch-2 branch June 24, 2021 11:19
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@LittleFall @3AceShowHand
add docs for enforce mpp (pingcap#6250)
e4cfd2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@hanfei1991 hanfei1991 hanfei1991 approved these changes

Assignees

@Joyinqin Joyinqin

Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.1 This PR/issue applies to TiDB v5.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@LittleFall @TomShawn @qiancai @ti-chi-bot @Joyinqin @hanfei1991 @CharLotteiu @Liuxiaozhen12