Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: add instruction to custom exist offline mirror #6633

Merged
merged 5 commits into from
Jul 15, 2021
Merged

tiup: add instruction to custom exist offline mirror #6633

merged 5 commits into from
Jul 15, 2021

Conversation

AstroProfundis
Copy link
Contributor

@AstroProfundis AstroProfundis commented Jul 6, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add instructions of how to customize exist offline mirror with TiUP. Typically useful when the user is using an offline mirror and want to upgrade TiUP itself without upgrading TiDB components.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@AstroProfundis AstroProfundis self-assigned this Jul 6, 2021
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 6, 2021
lilyjazz
lilyjazz approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@lilyjazz lilyjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@lilyjazz: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 7, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 7, 2021 •
edited
Loading

@AstroProfundis Assignees in docs-cn PRs mean the translator who is assigned to translate the PR to English. Do you want to be the translator?😀

@TomShawn
Copy link
Contributor

TomShawn commented Jul 7, 2021

@lucklove PTAL

@AstroProfundis
Copy link
Contributor Author

@AstroProfundis Assignees in docs-cn PRs mean the translator who is assigned to translate the PR to English. Do you want to be the translator?grinning

Ummm, no ><

lucklove
lucklove approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 7, 2021
@TomShawn TomShawn assigned en-jin19 and unassigned AstroProfundis Jul 12, 2021
TomShawn
TomShawn reviewed Jul 12, 2021
View reviewed changes
production-deployment-using-tiup.md Outdated Show resolved Hide resolved
production-deployment-using-tiup.md Outdated Show resolved Hide resolved
production-deployment-using-tiup.md Outdated Show resolved Hide resolved
production-deployment-using-tiup.md Outdated Show resolved Hide resolved
production-deployment-using-tiup.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added type/enhancement The issue or PR belongs to an enhancement. and removed needs-cherry-pick-release-5.0 labels Jul 14, 2021
AstroProfundis and others added 2 commits July 15, 2021 16:51
@AstroProfundis @TomShawn
Apply suggestions from code review
63a8a06 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Update release-2.0.11.md
278a7bb
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2021
TomShawn
TomShawn approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6083de4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2021
@ti-chi-bot ti-chi-bot merged commit 86d6eab into pingcap:master Jul 15, 2021
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@AstroProfundis @3AceShowHand
tiup: add instruction to custom exist offline mirror (pingcap#6633)
5d68740
@en-jin19 en-jin19 mentioned this pull request Aug 10, 2021
Merged
11 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 10, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 31, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@lilyjazz lilyjazz lilyjazz approved these changes

@lucklove lucklove lucklove approved these changes

Assignees

@en-jin19 en-jin19

Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AstroProfundis @ti-chi-bot @TomShawn @lucklove @lilyjazz @en-jin19