Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statement summary: update statement summary doc #6695

Merged
merged 18 commits into from
Jul 23, 2021
Merged

statement summary: update statement summary doc #6695

merged 18 commits into from
Jul 23, 2021

Conversation

ClSlaid
Copy link
Contributor

@ClSlaid ClSlaid commented Jul 16, 2021 •
edited by TomShawn
Loading

Signed-off-by: ClSlaid cailue@bupt.edu.cn

First-time contributors' checklist

What is changed, added or deleted? (Required)

Update document of statement summary.
Adding document for the new table statements_summary_evicted.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ClSlaid
update statement summary doc
8403409 
Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jul 16, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn July 16, 2021 11:13
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2021
@ClSlaid
增加配置示例
d0cbe8a 
Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 17, 2021
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. type/refactor The issue belongs to a refactor work. labels Jul 19, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 19, 2021
@ClSlaid
润色 statement summary table 说明
11b7d32 
Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
crazycs520 and others added 2 commits July 19, 2021 12:45
@crazycs520
Update statement-summary-tables.md
437599f
@ClSlaid
润色 statements summary
b394d9c 
Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
TomShawn
TomShawn approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 23, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 359850b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 23, 2021
@TomShawn TomShawn removed the type/refactor The issue belongs to a refactor work. label Jul 23, 2021
@ti-chi-bot ti-chi-bot merged commit 35151f8 into pingcap:master Jul 23, 2021
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@ClSlaid @3AceShowHand
statement summary: update statement summary doc (pingcap#6695)
4866f1f
@TomShawn TomShawn self-assigned this Aug 2, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 2, 2021
Merged
8 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6787.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Aug 2, 2021
@ClSlaid @ti-chi-bot
This is an automated cherry-pick of pingcap#6695
078c14f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Aug 2, 2021
@ti-chi-bot
statement summary: update statement summary doc (#6695) (#6787)
4f89927
TomShawn added a commit to TomShawn/docs that referenced this pull request Aug 3, 2021
@TomShawn
https://github.com/pingcap/docs-cn/pull/6695
7bb688a
@TomShawn TomShawn mentioned this pull request Aug 3, 2021
Merged
11 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 3, 2021
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Aug 3, 2021
Merged
11 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 3, 2021
Merged
11 tasks
github-actions bot pushed a commit to TomShawn/docs that referenced this pull request Aug 4, 2021
@TomShawn
https://github.com/pingcap/docs-cn/pull/6695
68bb35b
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2021
Merged
11 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Aug 26, 2021
@TomShawn @ti-chi-bot
https://github.com/pingcap/docs-cn/pull/6695
3fae774
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2021
Merged
11 tasks
@nongfushanquan nongfushanquan mentioned this pull request Aug 29, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees

@TomShawn TomShawn

Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ClSlaid @ti-chi-bot @TomShawn @crazycs520