Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update stale read doc for ga #6715

Merged
merged 2 commits into from
Jul 28, 2021
Merged

update stale read doc for ga #6715

merged 2 commits into from
Jul 28, 2021

Conversation

NingLin-P
Copy link
Contributor

@NingLin-P NingLin-P commented Jul 22, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions) 补充是从 v5.1.1 GA 的
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@NingLin-P
update stale read doc
eec040a 
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P
ga stale read
8c091f1 
Signed-off-by: linning <linningde25@gmail.com>
@ti-chi-bot ti-chi-bot requested a review from TomShawn July 22, 2021 06:23
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2021
@NingLin-P NingLin-P requested review from nolouch, Yisaer and TomShawn and removed request for TomShawn July 22, 2021 06:23
@TomShawn
Copy link
Contributor

是否需要说明一下，Stale Read 是从哪个 TiDB版本起 GA 的？

@TomShawn TomShawn added needs-cherry-pick-release-5.1 translation/doing This PR’s assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Jul 22, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 22, 2021
@TomShawn TomShawn changed the title Update stale read doc update stale read doc for ga Jul 22, 2021
@NingLin-P
Copy link
Contributor Author

是否需要说明一下，Stale Read 是从哪个 TiDB版本起 GA 的？

从 v5.1.1 开始，这个具体要写到那个文档呀，还是只要写到 release note 就可以了

@nolouch
Copy link
Member

nolouch commented Jul 23, 2021

lgtm, cc @Yisaer

@TomShawn TomShawn added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Jul 23, 2021
@TomShawn
Copy link
Contributor

是否需要说明一下，Stale Read 是从哪个 TiDB版本起 GA 的？

从 v5.1.1 开始，这个具体要写到那个文档呀，还是只要写到 release note 就可以了

写到 cherry-pick 到 release-5.1 的文档中

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • Yisaer

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2021
@ti-chi-bot
Copy link
Member

@nolouch: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn assigned TomShawn and unassigned en-jin19 Jul 28, 2021
@NingLin-P
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@NingLin-P: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8c091f1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2021
@ti-chi-bot ti-chi-bot merged commit ef66f6b into pingcap:master Jul 28, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6753.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 28, 2021
Merged
12 tasks
@TomShawn TomShawn mentioned this pull request Jul 29, 2021
Merged
11 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 29, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 29, 2021
Merged
11 tasks
ti-chi-bot added a commit that referenced this pull request Jul 30, 2021
@ti-chi-bot
update stale read doc for ga (#6715) (#6753)
ad28bfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@Yisaer Yisaer Yisaer approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees

@TomShawn TomShawn

Labels
requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NingLin-P @TomShawn @nolouch @ti-chi-bot @Yisaer @en-jin19