Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure time zone: mention system_time_zone #6793

Merged
merged 3 commits into from
Aug 5, 2021
Merged

Configure time zone: mention system_time_zone #6793

merged 3 commits into from
Aug 5, 2021

Conversation

en-jin19
Copy link
Contributor

@en-jin19 en-jin19 commented Aug 2, 2021

What is changed, added or deleted? (Required)

added system_time_zone in the ”Configure time zone".

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@en-jin19 en-jin19 added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs This PR is translated from a PR in pingcap/docs. labels Aug 2, 2021
@en-jin19 en-jin19 requested a review from TomShawn August 2, 2021 11:20
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 2, 2021
TomShawn
TomShawn reviewed Aug 5, 2021
View reviewed changes
configure-time-zone.md Outdated
@@ -27,12 +27,12 @@ TiDB 还可以通过设置 session 变量 `time_zone` 为每个连接维护各
SET time_zone = timezone;
```

查看当前使用的时区的值：
查看当前系统使用的时区的值：
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
查看当前系统使用的时区的值：
使用以下 SQL 语句查看当前全局时区、客户端时区和系统时区的值：

@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Aug 5, 2021
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Aug 5, 2021
TomShawn
TomShawn approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 5, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Aug 5, 2021

/merge

@ti-chi-bot
Copy link
Member

@TomShawn: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 5, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Aug 5, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9294f9b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2021
@ti-chi-bot ti-chi-bot merged commit ddce068 into pingcap:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@en-jin19 @ti-chi-bot @TomShawn