Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description about table name/alias specifying for read_from_storage hint #6861

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Add description about table name/alias specifying for read_from_storage hint #6861

merged 2 commits into from
Aug 26, 2021

Conversation

zanmato1984
Copy link
Contributor

@zanmato1984 zanmato1984 commented Aug 13, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add description about table name/alias specifying for read_from_storage hint.

Which TiDB version(s) do your changes apply to? (Required)

master, 5.2, 5.1, 5.1, 4.0

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 13, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2021
@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Aug 13, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Aug 13, 2021
@TomShawn TomShawn added the type/enhancement The issue or PR belongs to an enhancement. label Aug 13, 2021
@TomShawn TomShawn assigned zanmato1984 and unassigned hfxsd Aug 13, 2021
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 13, 2021
@TomShawn TomShawn mentioned this pull request Aug 13, 2021
Merged
12 tasks
windtalker
windtalker approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@windtalker: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed Aug 26, 2021
View reviewed changes
optimizer-hints.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@TomShawn: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 26, 2021
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 26, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2bfbcc4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 26, 2021
@ti-chi-bot ti-chi-bot merged commit a43ef23 into master Aug 26, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6985.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6986.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6987.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6988.

This was referenced Aug 26, 2021
Merged
Merged
Merged
Merged
@TomShawn TomShawn deleted the refine-read-from-storage-hint branch August 26, 2021 07:11
ti-chi-bot added a commit that referenced this pull request Aug 26, 2021
@ti-chi-bot
Add description about table name/alias specifying for read_from_stora…
8499024 
…ge hint (#6861) (#6985)
ti-chi-bot added a commit that referenced this pull request Aug 26, 2021
@ti-chi-bot
Add description about table name/alias specifying for read_from_stora…
2d7adba 
…ge hint (#6861) (#6986)
ti-chi-bot added a commit that referenced this pull request Aug 26, 2021
@ti-chi-bot
Add description about table name/alias specifying for read_from_stora…
8408b39 
…ge hint (#6861) (#6987)
ti-chi-bot added a commit that referenced this pull request Aug 26, 2021
@ti-chi-bot
Add description about table name/alias specifying for read_from_stora…
9522975 
…ge hint (#6861) (#6988)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@windtalker windtalker windtalker approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees

@zanmato1984 zanmato1984

Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zanmato1984 @ti-chi-bot @TomShawn @windtalker @hfxsd