Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alert rule for low space #6978

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Update alert rule for low space #6978

merged 1 commit into from
Aug 30, 2021

Conversation

tabokie
Copy link
Contributor

@tabokie tabokie commented Aug 26, 2021

What is changed, added or deleted? (Required)

tikv/tikv#10807

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 26, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 26, 2021
@TomShawn TomShawn requested a review from glkappe August 26, 2021 05:08
@TomShawn TomShawn added needs-cherry-pick-release-4.0 require-LGT1 Indicates that the PR requires an LGTM. type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 26, 2021
@TomShawn
Copy link
Contributor

@tabokie Please sign Contributor License Agreement for this PR to merge. Thanks!

@TomShawn
Copy link
Contributor

@glkappe If the content is OK, please comment LGTM. Thanks!

@TomShawn TomShawn added the status/PTAL This PR is ready for reviewing. label Aug 30, 2021
Copy link
Contributor

@glkappe glkappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 30, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 30, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 78f9262

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@ti-chi-bot ti-chi-bot merged commit 7ea5c1c into pingcap:master Aug 30, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7029.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7030.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7031.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7032.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants