Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually revert ""add dr auto sync" #6990

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Manually revert ""add dr auto sync" #6990

merged 2 commits into from
Aug 26, 2021

Conversation

Liuxiaozhen12
Copy link
Contributor

Manually revert #6843.

@Liuxiaozhen12 Liuxiaozhen12 added translation/doing This PR’s assignee is translating this PR. v5.2 This PR/issue applies to TiDB v5.2. needs-cherry-pick-release-5.2 labels Aug 26, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 26, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Liuxiaozhen12 Liuxiaozhen12 self-assigned this Aug 26, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 26, 2021
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Aug 26, 2021
Merged
@Liuxiaozhen12 Liuxiaozhen12 changed the title revert https://github.com/pingcap/docs-cn/pull/6843 Manually revert ""add dr auto sync" Aug 26, 2021
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 26, 2021
@ti-chi-bot
Copy link
Member

@nolouch: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 26, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 26, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 37d554a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 26, 2021
@ti-chi-bot ti-chi-bot merged commit 803c391 into pingcap:master Aug 26, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6991.

ti-chi-bot added a commit that referenced this pull request Aug 26, 2021
@ti-chi-bot
Manually revert ""add dr auto sync" (#6990) (#6991)
afa16dc
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2021
Merged
@Liuxiaozhen12 Liuxiaozhen12 deleted the revert-one-city branch August 26, 2021 10:16
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Oct 8, 2021
Merged
13 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 8, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.2 This PR/issue applies to TiDB v5.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Liuxiaozhen12 @ti-chi-bot @TomShawn @nolouch