Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning messages #7016

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Conversation

Liuxiaozhen12
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Liuxiaozhen12 Liuxiaozhen12 added translation/from-docs This PR is translated from a PR in pingcap/docs. type/bugfix This PR fixes a bug. needs-cherry-pick-release-4.0 labels Aug 30, 2021
@Liuxiaozhen12 Liuxiaozhen12 self-assigned this Aug 30, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 30, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 30, 2021
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2021
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Sep 1, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Sep 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: af78d87

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2021
@ti-chi-bot ti-chi-bot merged commit 803cab2 into pingcap:master Sep 1, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 1, 2021
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7045.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 1, 2021
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7046.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 1, 2021
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7047.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 1, 2021
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7048.

ti-chi-bot added a commit that referenced this pull request Sep 1, 2021
ti-chi-bot added a commit that referenced this pull request Sep 1, 2021
ti-chi-bot added a commit that referenced this pull request Sep 1, 2021
ti-chi-bot added a commit that referenced this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants