Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support using task-file when need task-name (#220) #239

Merged
merged 8 commits into from
Aug 17, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #220 to release-1.0


What is changed, added or deleted? (Required)

support using task-file when need task-name

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v2.0 changes for now)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added size/small Changes of a small size. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-1.0 This PR is cherry-picked to release-1.0 from a source PR. v2.0 This PR/issue applies to TiDB DM v2.0. labels Aug 17, 2020
@ti-srebot
Copy link
Contributor Author

@lance6716 please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/docs-dm/invitations

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lance6716 Please make v1.0-specific changes in this PR. Some documents that do not exist in v1.0 are cherry-picked to v1.0.

@TomShawn TomShawn added the status/require-change The author needs to address comments. label Aug 17, 2020
@lance6716
Copy link
Contributor

done @TomShawn

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2020
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Aug 17, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 0a5c01c into pingcap:release-1.0 Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. status/require-change The author needs to address comments. type/cherry-pick-for-release-1.0 This PR is cherry-picked to release-1.0 from a source PR. v2.0 This PR/issue applies to TiDB DM v2.0.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants