support using task-file when need task-name (#257) #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
6 tasks
ti-srebot
added
size/small
|
@Joyinqin please accept the invitation then you can push to the cherry-pick pull requests. |
|
I'm working on this. |
|
@lance6716 PTAL |
lance6716
reviewed
Aug 19, 2020
en/manage-replication-tasks.md
Outdated
| @@ -14,6 +14,10 @@ The dmctl component supports the interactive mode for manual operations, and als | |||
|
|
|||
| This section describes the basic use of dmctl commands in the interactive mode. | |||
|
|
|||
| > **Note:** | |||
| > | |||
| > The interactive mode does not support Bash features. For example, you need to directly pass string flags instead of passing them in quotation marks. | |||
There was a problem hiding this comment.
seems coders casually say "quotes" instead of "quotation marks"
|
@lance6716,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack). |
1 similar comment
|
@lance6716,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack). |
lilin90
reviewed
Aug 19, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #257 to release-1.0
What is changed, added or deleted? (Required)
support using task-file when need task-name
Which DM version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?