Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh: add a notice about topology example for scale-out #348

Merged
merged 2 commits into from
Sep 7, 2020
Merged

zh: add a notice about topology example for scale-out #348

merged 2 commits into from
Sep 7, 2020

Conversation

csuzhangxc
Copy link
Member

What is changed, added or deleted? (Required)

add a notice about topology example for scale-out via TiUP.

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts after cherry-picked

@csuzhangxc
Copy link
Member Author

@lance6716 @ireneontheway PTAL

lance6716
lance6716 reviewed Sep 4, 2020
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果给仓库路径的话，可能会改名。commit路径的话不能更新 🤣

@csuzhangxc
Copy link
Member Author

csuzhangxc commented Sep 4, 2020 •
edited
Loading

如果给仓库路径的话，可能会改名。commit路径的话不能更新 🤣

我们把这个文件 copy 过来？但这样又有一个问题，就是每次更新 TiUP DM 配置示例都得重新 copy 一次。

@lance6716
Copy link
Contributor

lance6716 commented Sep 4, 2020 via email

@ireneontheway ireneontheway self-requested a review September 7, 2020 02:11
@ireneontheway ireneontheway added needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Sep 7, 2020
@ireneontheway ireneontheway self-assigned this Sep 7, 2020
@lance6716
Copy link
Contributor

LGTM

@ti-srebot
Copy link
Contributor

@lance6716,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

yikeke
yikeke approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2020
@yikeke
Copy link
Contributor

yikeke commented Sep 7, 2020

不知道能不能做死链检测啥的，要是能的话，就放master的好了 Xuecheng Zhang notifications@github.com 于 2020年9月4日周五 18:26写道：
…
如果给仓库路径的话，可能会改名。commit路径的话不能更新 🤣 我们把这个文件 copy 过来？但这样又有一个问题，就是每次更新 TiUP DM 都得重新 copy 一次。 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#348 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAM4RJWAIHUB5XMLWT375TTSEC6E3ANCNFSM4QX7D3JQ .

感谢提需求😁，学程哥在 #353 实现了

@yikeke yikeke added the require-LGT1 Indicates that the PR requires an LGTM. label Sep 7, 2020
@yikeke
Copy link
Contributor

yikeke commented Sep 7, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 8f64a7c into pingcap:master Sep 7, 2020
ti-srebot pushed a commit to ti-srebot/docs-dm that referenced this pull request Sep 7, 2020
@csuzhangxc @ti-srebot
cherry pick pingcap#348 to release-2.0
82a97b3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 7, 2020
Merged
7 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #359

yikeke pushed a commit that referenced this pull request Sep 7, 2020
@ti-srebot @csuzhangxc
cherry pick #348 to release-2.0 (#359)
0de52f3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>
@ireneontheway ireneontheway added translation/done This PR has been translated. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 9, 2020
@ireneontheway ireneontheway mentioned this pull request Sep 9, 2020
Merged
7 tasks
@ti-srebot ti-srebot mentioned this pull request Sep 9, 2020
Merged
7 tasks
@csuzhangxc csuzhangxc deleted the refine-tiup-scale branch September 10, 2020 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ireneontheway ireneontheway ireneontheway left review comments

@lance6716 lance6716 lance6716 left review comments

@yikeke yikeke yikeke approved these changes

Assignees

@ireneontheway ireneontheway

Labels
needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csuzhangxc @lance6716 @ti-srebot @yikeke @ireneontheway