Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh: update target settings in config file (#445) #449

Merged
merged 1 commit into from
Oct 27, 2020
Merged

zh: update target settings in config file (#445) #449

merged 1 commit into from
Oct 27, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #445 to release-2.0

What is changed, added or deleted? (Required)

align with pingcap/dm#1032

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts after cherry-picked

@lance6716 @ti-srebot
cherry pick pingcap#445 to release-2.0
3bcdedf 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 27, 2020
Merged
7 tasks
@ti-srebot ti-srebot added size/small Changes of a small size. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-2.0 This PR is cherry-picked to release-2.0 from a source PR. labels Oct 27, 2020
csuzhangxc
csuzhangxc reviewed Oct 27, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2020
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2020
@yikeke yikeke merged commit ac79d17 into pingcap:release-2.0 Oct 27, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@yikeke yikeke yikeke approved these changes

@CharLotteiu CharLotteiu Awaiting requested review from CharLotteiu

Assignees

@lance6716 lance6716

Labels
size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-2.0 This PR is cherry-picked to release-2.0 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @csuzhangxc @yikeke @lance6716