Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0.2] *: add transfer-source command #605

Merged
merged 19 commits into from
Apr 9, 2021
Merged

[2.0.2] *: add transfer-source command #605

merged 19 commits into from
Apr 9, 2021

Conversation

lance6716
Copy link
Contributor

What is changed, added, or deleted? (Required)

align with pingcap/dm#1492

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2021
@lance6716
Copy link
Contributor Author

/cc @GMHDBJD

@ti-chi-bot ti-chi-bot requested a review from GMHDBJD April 1, 2021 08:16
@lance6716 lance6716 changed the title add transfer-source command [2.0.2] add transfer-source command Apr 2, 2021
@CharLotteiu
Copy link
Contributor

/label needs-cherry-pick-2.0
/translation no-need
/status PTAL
/cc @CharLotteiu

@ti-chi-bot ti-chi-bot added translation/no-need The changes in this PR don't need to be translated. status/PTAL This PR is ready for reviewing. needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. and removed missing-translation-status This PR does not have translation status info. labels Apr 2, 2021
GMHDBJD
GMHDBJD reviewed Apr 2, 2021
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

zh/manage-source.md Outdated
@@ -22,9 +22,9 @@ aliases: ['/docs-cn/tidb-data-migration/dev/manage-source/']
MKxn0Qo3m3XOyjCnhEMtsUCm83EhGQDZ/T4=
```

## 加载数据源配置
## 加载、列出、移除数据源
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

换个标题，比如数据源操作？

@ran-huang
Copy link
Contributor

/retitle [2.0.2] *: add transfer-source command

@ti-chi-bot ti-chi-bot changed the title [2.0.2] add transfer-source command [2.0.2] *: add transfer-source command Apr 2, 2021
CharLotteiu
CharLotteiu reviewed Apr 2, 2021
View reviewed changes
en/manage-source.md Outdated Show resolved Hide resolved
en/manage-source.md Outdated Show resolved Hide resolved
en/manage-source.md Outdated Show resolved Hide resolved
en/manage-source.md Outdated Show resolved Hide resolved
en/manage-source.md Outdated Show resolved Hide resolved
en/manage-source.md Outdated Show resolved Hide resolved
en/manage-source.md Outdated Show resolved Hide resolved
en/manage-source.md Outdated Show resolved Hide resolved
en/manage-source.md Outdated Show resolved Hide resolved
zh/manage-source.md Outdated
```

在进行改变之前，DM 会检查旧 worker 是否正在运行同步任务，如果正在运行则需要先[暂停任务](pause-task.md)，并在改变绑定关系后[恢复任务](resume-task.md)。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does 旧 worker mean? The free worker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the worker that will unbind. Will change description later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12cbfef

PTAL

@CharLotteiu
Copy link
Contributor

/cc @yikeke

@ti-chi-bot ti-chi-bot requested a review from yikeke April 6, 2021 07:39
@CharLotteiu CharLotteiu mentioned this pull request Apr 8, 2021
Merged
7 tasks
yikeke
yikeke reviewed Apr 9, 2021
View reviewed changes
en/manage-source.md Outdated Show resolved Hide resolved
en/manage-source.md Outdated Show resolved Hide resolved
en/manage-source.md Outdated Show resolved Hide resolved
en/manage-source.md Outdated Show resolved Hide resolved
en/manage-source.md Outdated Show resolved Hide resolved
en/manually-upgrade-dm-1.0-to-2.0.md Outdated Show resolved Hide resolved
en/performance-test.md Outdated Show resolved Hide resolved
en/performance-test.md Outdated Show resolved Hide resolved
en/config-overview.md Outdated Show resolved Hide resolved
@yikeke
Copy link
Contributor

yikeke commented Apr 9, 2021 •
edited
Loading

There are some external link errors:
image

Please fix them in a new PR. @CharLotteiu

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 9, 2021
@yikeke
Copy link
Contributor

yikeke commented Apr 9, 2021

/lgtm

@CharLotteiu CharLotteiu mentioned this pull request Apr 9, 2021
Merged
7 tasks
@ti-srebot ti-srebot mentioned this pull request Apr 9, 2021
Merged
7 tasks
@CharLotteiu
Copy link
Contributor

/rebase

lance6716 and others added 16 commits April 9, 2021 07:33
@lance6716 @CharLotteiu
fix CI
f8370df
@lance6716 @CharLotteiu
add translation
dae418e
@lance6716 @CharLotteiu
fix CI
70ee46f
@lance6716 @CharLotteiu
address comments
5aa621d
@lance6716 @CharLotteiu
Update en/manage-source.md
7db61cd 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@lance6716 @CharLotteiu
Update en/manage-source.md
e7c106f 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@lance6716 @CharLotteiu
Update en/manage-source.md
b316ace 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@lance6716 @CharLotteiu
Update en/manage-source.md
64e52f6 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@lance6716 @CharLotteiu
Update en/manage-source.md
5ffdbe4 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@lance6716 @CharLotteiu
Update en/manage-source.md
1add6b0 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@lance6716 @CharLotteiu
Update en/manage-source.md
44aedb7 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@lance6716 @CharLotteiu
Update en/manage-source.md
75392fe 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@lance6716 @CharLotteiu
Update en/manage-source.md
2d9dad3 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@lance6716 @CharLotteiu
address comment
fef29ef
@lance6716 @yikeke @CharLotteiu
Apply suggestions from code review
8078993 
Co-authored-by: Coco Yee <40977455+yikeke@users.noreply.github.com>
@lance6716 @yikeke @CharLotteiu
Update en/manage-source.md
6af6a32 
Co-authored-by: Coco Yee <40977455+yikeke@users.noreply.github.com>
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Apr 9, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • yikeke

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 9, 2021
@CharLotteiu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4e5c466

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 9, 2021
@ti-chi-bot ti-chi-bot merged commit e6b1139 into pingcap:master Apr 9, 2021
ti-srebot pushed a commit to ti-srebot/docs-dm that referenced this pull request Apr 9, 2021
@lance6716 @ti-srebot
cherry pick pingcap#605 to release-2.0
6bd4478 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 9, 2021
Merged
7 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #617

ti-chi-bot pushed a commit that referenced this pull request Apr 9, 2021
@ti-srebot
[2.0.2] *: add transfer-source command (#605) (#617)
b8c9bd8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharLotteiu CharLotteiu CharLotteiu left review comments

@GMHDBJD GMHDBJD GMHDBJD left review comments

@yikeke yikeke yikeke approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/no-need The changes in this PR don't need to be translated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lance6716 @CharLotteiu @ran-huang @yikeke @GMHDBJD @ti-chi-bot @ti-srebot