Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

en: add doc about volume snapshot backup/restore across multiple kubernetes #2406

Merged
merged 40 commits into from
Sep 1, 2023
Merged

en: add doc about volume snapshot backup/restore across multiple kubernetes #2406

merged 40 commits into from
Sep 1, 2023

Conversation

WangLe1321
Copy link
Contributor

@WangLe1321 WangLe1321 commented Jul 7, 2023 •
edited by ran-huang
Loading

What is changed, added, or deleted? (Required)

Preview:

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@WangLe1321
br: add doc about deploy and use br federation
b0c5c82 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@ti-chi-bot ti-chi-bot bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 7, 2023
@CLAassistant
Copy link

CLAassistant commented Jul 7, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 7, 2023
@WangLe1321
br: add doc about backup schedule
1ba45b4 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@BornChanger BornChanger mentioned this pull request Jul 12, 2023
Open
@WangLe1321
br: modify docs about kubeconfig and br-federation-manager deployment
584dace 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 2, 2023
@WangLe1321
en: remove unused symbols and add comments
031f893 
Signed-off-by: WangLe1321 <wangle1321@163.com>
@WangLe1321 WangLe1321 changed the title [WIP] br: add doc about deploy and use br federation en: add doc about volume snapshot backup/restore across multiple kubernetes Aug 2, 2023
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2023
github-actions bot pushed a commit to ran-huang/pingcap-docs-website-scaffold that referenced this pull request Aug 2, 2023
Preview PR pingcap/docs-tidb-operator#2406 and this preview is trigge…
783db94 
…red from commit pingcap/docs-tidb-operator@031f893
ran-huang
ran-huang reviewed Aug 2, 2023
View reviewed changes
en/TOC.md Outdated Show resolved Hide resolved
en/TOC.md Show resolved Hide resolved
en/backup-by-ebs-snapshot-across-multiple-kubernetes.md Outdated Show resolved Hide resolved
en/backup-by-ebs-snapshot-across-multiple-kubernetes.md Outdated Show resolved Hide resolved
en/backup-by-ebs-snapshot-across-multiple-kubernetes.md Outdated Show resolved Hide resolved
en/deploy-br-federation-manager.md Outdated Show resolved Hide resolved
en/deploy-br-federation-manager.md Outdated Show resolved Hide resolved
en/deploy-br-federation-manager.md Outdated Show resolved Hide resolved
en/deploy-br-federation-manager.md Outdated Show resolved Hide resolved
en/backup-by-ebs-snapshot-across-multiple-kubernetes.md Outdated Show resolved Hide resolved
@ran-huang ran-huang added the translation/doing This PR’s assignee is translating this PR. label Aug 2, 2023
WangLe1321 and others added 2 commits August 23, 2023 18:44
@WangLe1321 @ran-huang
Apply suggestions from code review
f304104 
Co-authored-by: Ran <huangran.alex@gmail.com>
@WangLe1321
en: update docs by comment
4462641 
Signed-off-by: WangLe1321 <wangle1321@163.com>
github-actions bot pushed a commit to ran-huang/pingcap-docs-website-scaffold that referenced this pull request Aug 24, 2023
Preview PR pingcap/docs-tidb-operator#2406 and this preview is trigge…
68c53e6 
…red from commit pingcap/docs-tidb-operator@4462641
@WangLe1321 @ran-huang @BornChanger
Apply suggestions from code review
67052b3 
Co-authored-by: Ran <huangran.alex@gmail.com>
Co-authored-by: BornChanger <97348524+BornChanger@users.noreply.github.com>
WangLe1321 and others added 2 commits August 24, 2023 18:23
@WangLe1321 @ran-huang
Update en/backup-by-ebs-snapshot-across-multiple-kubernetes.md
7cab2fe 
Co-authored-by: Ran <huangran.alex@gmail.com>
github-actions bot pushed a commit to ran-huang/pingcap-docs-website-scaffold that referenced this pull request Aug 25, 2023
Preview PR pingcap/docs-tidb-operator#2406 and this preview is trigge…
368331d 
…red from commit pingcap/docs-tidb-operator@7cab2fe
@BornChanger
Copy link
Contributor

Any pending comments or issues now? @WangLe1321 @ran-huang

@WangLe1321 @ran-huang
Apply suggestions from code review
529ee8e 
Co-authored-by: Ran <huangran.alex@gmail.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 1, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-01 09:48:07.736094179 +0000 UTC m=+2093252.285110165: ☑️ agreed by ran-huang.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 1, 2023

@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ran-huang ran-huang added the lgtm label Sep 1, 2023
@ran-huang
Copy link
Contributor

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 1, 2023
@ti-chi-bot ti-chi-bot bot merged commit c89f4fd into pingcap:master Sep 1, 2023
11 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.5: #2446.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 1, 2023
Merged
5 tasks
ran-huang added a commit that referenced this pull request Sep 1, 2023
@ran-huang
Revert "en: add doc about volume snapshot backup/restore across multi…
3ab78ee 
…ple kubernetes (#2406)"

This reverts commit c89f4fd.
@ran-huang ran-huang mentioned this pull request Sep 1, 2023
Closed
ti-chi-bot bot pushed a commit that referenced this pull request Jan 19, 2024
@ti-chi-bot
en: add doc about volume snapshot backup/restore across multiple kube…
d48d831 
…rnetes (#2406) (#2446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivia-chen-github olivia-chen-github olivia-chen-github left review comments

@lilin90 lilin90 lilin90 left review comments

@wxiaomou wxiaomou wxiaomou left review comments

@danp60 danp60 danp60 left review comments

@BornChanger BornChanger BornChanger approved these changes

@ran-huang ran-huang ran-huang approved these changes

Assignees

@ran-huang ran-huang

Labels
approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@WangLe1321 @CLAassistant @lilin90 @BornChanger @ran-huang @ti-chi-bot @danp60 @wxiaomou @olivia-chen-github