Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Grace Cai <qqzczy@126.com>
  • Loading branch information
CharLotteiu and qiancai committed Apr 15, 2021
1 parent fb1f116 commit 52d0c78
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
4 changes: 2 additions & 2 deletions tiup/tiup-component-cluster-rename.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ The cluster name is specified when [the cluster is deployed](/tiup/tiup-componen

> **Note:**
>
> If the tiup cluster is configured with the `dashboard_dir` field of `grafana_servers`, when you execute the command `tiup cluster rename` to rename the cluster, the following additional steps are required:
> If the `dashboard_dir` field of `grafana_servers` is configured for the TiUP cluster, after you execute the command `tiup cluster rename` to rename the cluster, the following additional steps are required:
>
> + For the `*.json` files in the local dashboards directory, update the `datasource` field of each file to the new cluster name, because the value of `datasource` must be the name of the cluster.
> + Execute the command `tiup cluster reload -R grafana`.
Expand All @@ -32,4 +32,4 @@ tiup cluster rename <old-cluster-name> <new-cluster-name> [flags]

## Outputs

The execution log of the tiup-cluster.
The execution log of the tiup-cluster.
12 changes: 5 additions & 7 deletions tiup/tiup-component-cluster-restart.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,12 @@ tiup cluster restart <cluster-name> [flags]

`<cluster-name>`: the name of the cluster to operate on. If you forget the cluster name, you can check it with the [cluster list](/tiup/tiup-component-cluster-list.md) command.

`<cluster-name>`

## Options

### -N, --node

- Specifies the nodes to be restarted. The value of this option is a comma-separated list of node IDs. You can get the node ID from the first column of the [cluster status table](/tiup/tiup-component-cluster-display.md).
- Data type: `STRINGS`
- Specifies the nodes to be restarted. The value of this option is a comma-separated list of node IDs. You can get the node IDs from the first column of the [cluster status table](/tiup/tiup-component-cluster-display.md) returned by the `tiup cluster display` command.
- Data type: `STRING`
- If this option is not specified, TiUP restarts all nodes by default.

> **Note:**
Expand All @@ -34,8 +32,8 @@ tiup cluster restart <cluster-name> [flags]
### -R, --role

- Specified roles of nodes to be restarted. The value of this option is a comma-separated list of the roles of the nodes. You can get the roles of the nodes from the second column of the [cluster status table](/tiup/tiup-component-cluster-display.md).
- Data type: `STRINGS`
- Specified the roles of nodes to be restarted. The value of this option is a comma-separated list of the roles of the nodes. You can get the roles of the nodes from the second column of the [cluster status table](/tiup/tiup-component-cluster-display.md) returned by the `tiup cluster display` command.
- Data type: `STRING`
- If this option is not specified, TiUP restarts nodes of all roles by default.

> **Note:**
Expand All @@ -50,4 +48,4 @@ tiup cluster restart <cluster-name> [flags]

## Outputs

The log of the service restart process.
The log of the service restart process.

0 comments on commit 52d0c78

Please sign in to comment.